Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-3566 fix sql injection in create binding request #7984

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Aug 19, 2024

Changelog entry

Fixed '\' escaping

Changelog category

  • Bugfix

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner August 19, 2024 08:25
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 08:28:08 UTC Pre-commit check for f76a3d9 has started.
2024-08-19 08:31:00 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-19 10:49:17 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10076 9990 0 18 34 34

🟢 2024-08-19 10:50:09 UTC Build successful.
🟢 2024-08-19 10:50:38 UTC ydbd size 5.5 GiB changed* by -68.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 274bfdd merge: f76a3d9 diff diff %
ydbd size 5 880 316 984 Bytes 5 880 247 400 Bytes -68.0 KiB -0.001%
ydbd stripped size 1 477 405 904 Bytes 1 477 395 728 Bytes -9.9 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA requested a review from uzhastik August 19, 2024 08:28
Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 08:29:03 UTC Pre-commit check for f76a3d9 has started.
2024-08-19 08:31:52 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-19 08:37:04 UTC Build successful.

Copy link

github-actions bot commented Aug 19, 2024

2024-08-19 08:29:03 UTC Pre-commit check for f76a3d9 has started.
2024-08-19 08:31:51 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-19 09:54:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38765 33414 0 3 5311 37

2024-08-19 09:57:32 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-19 10:06:11 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 (only retried tests) 19 0 0 1 27

🟢 2024-08-19 10:06:18 UTC Build successful.
🟢 2024-08-19 10:07:24 UTC ydbd size 8.1 GiB changed* by -8 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 5522a96 merge: f76a3d9 diff diff %
ydbd size 8 736 888 376 Bytes 8 736 888 368 Bytes -8 Bytes -0.000%
ydbd stripped size 475 560 200 Bytes 475 560 200 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 43019e6 into ydb-platform:main Aug 26, 2024
12 of 15 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3566-fix-sql-injection-in-create-binding-request branch August 26, 2024 13:10
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 26, 2024
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Aug 26, 2024
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Aug 28, 2024
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants