Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dq_input_transform_lookup: fix maxKeysInRequest logic #7592

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Aug 8, 2024

one row of data was lost once maxKeysInRequest reached

Changelog entry

...

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

one row of data was lost once maxKeysInRequest reached
@yumkam yumkam requested a review from zverevgeny August 8, 2024 17:07
@github-actions github-actions bot added the bugfix label Aug 8, 2024
@yumkam yumkam marked this pull request as ready for review August 8, 2024 17:07
@yumkam yumkam requested review from a team as code owners August 8, 2024 17:07
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 17:09:04 UTC Pre-commit check for 4965877 has started.
2024-08-08 17:12:39 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 19:20:48 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9548 9487 0 16 31 14

🟢 2024-08-08 19:21:59 UTC Build successful.
🟢 2024-08-08 19:22:28 UTC ydbd size 5.4 GiB changed* by +272 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78d1439 merge: 4965877 diff diff %
ydbd size 5 839 792 744 Bytes 5 839 793 016 Bytes +272 Bytes +0.000%
ydbd stripped size 1 467 330 960 Bytes 1 467 331 024 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam
Copy link
Collaborator Author

yumkam commented Aug 8, 2024

note that #5738 conflicts and will need refix/rebase

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 17:11:05 UTC Pre-commit check for 4965877 has started.
2024-08-08 17:13:57 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 19:11:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38132 32807 0 3 5309 13

2024-08-08 19:15:42 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 19:26:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 6 0 2 4 8

2024-08-08 19:26:57 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 19:33:49 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 6 0 0 0 8

🟢 2024-08-08 19:33:57 UTC Build successful.
🟢 2024-08-08 19:34:32 UTC ydbd size 8.1 GiB changed* by +504 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78d1439 merge: 4965877 diff diff %
ydbd size 8 682 534 824 Bytes 8 682 535 328 Bytes +504 Bytes +0.000%
ydbd stripped size 472 557 672 Bytes 472 557 672 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 17:11:06 UTC Pre-commit check for 4965877 has started.
2024-08-08 17:13:48 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 17:19:05 UTC Build successful.

@yumkam yumkam requested a review from rvu1024 August 14, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants