Remove the LaunchProfiles capability for the CPS integration #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements https://work.azdo.io/1112733 as a workaround for the conflicts between the built-in launchsettings.json-based .NET Core debugger and our Mono debugger.
kzu
requested review from
chamons,
emaf,
jstedfast and
VincentDondain
as code owners
rolfbjarne
approved these changes
Apr 29, 2020
|
Build failure 🔥 Build failed 🔥 |
spouliot
reviewed
Apr 29, 2020
| @@ -28,6 +28,10 @@ | |||
| <ItemGroup> | |||
| <ProjectCapability Include="Apple" /> | |||
| <ProjectCapability Include="Mobile" /> | |||
|
|
|||
| // See https://work.azdo.io/1112733 | |||
There was a problem hiding this comment.
^ as much as I like // that does not look legit here
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 6, 2020
…#8472) Implements https://work.azdo.io/1112733 as a workaround for the conflicts between the built-in launchsettings.json-based .NET Core debugger and our Mono debugger.
rolfbjarne
added a commit
that referenced
this pull request
Jul 6, 2020
* [.NET 5] Start adding some project capabilities (#3) Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too. * Remove the LaunchProfiles capability for the CPS integration (#8472) Implements https://work.azdo.io/1112733 as a workaround for the conflicts between the built-in launchsettings.json-based .NET Core debugger and our Mono debugger. Co-authored-by: Daniel Cazzulino <daniel@cazzulino.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://work.azdo.io/1112733 as a workaround for the conflicts between
the built-in launchsettings.json-based .NET Core debugger and our Mono debugger.