-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET 5] Start adding some project capabilities #4383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual Studio uses CPS to load SDK-style projects. In CPS, most things are keyed-off so-called capabilities[0] which replace other methods that were used previously like project type GUIDs. While capabilities can be defined in the IDE, they make most sense to be directly expressed in the targets themselves where CPS will pick them up automatically. [0] https://github.com/microsoft/VSProjectSystem/blob/master/doc/overview/about_project_capabilities.md
pjcollins
approved these changes
Mar 11, 2020
After discussing with @kzu, simply using `Android` could be confusing with native C++ Android project that export the same capability. By combining `Managed + Mobile + Android` we can make a clear distinction that we are dealing with a Xamarin.Android project
kzu
approved these changes
Mar 12, 2020
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 13, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 13, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 16, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 16, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 18, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 19, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Mar 25, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
pushed a commit
to xamarin/xamarin-macios
that referenced
this pull request
Mar 27, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
pjcollins
added a commit
that referenced
this pull request
Mar 31, 2020
Context: #4383 Visual Studio uses CPS to load SDK-style projects. In CPS, most things are keyed-off so-called capabilities[0] which replace other methods that were used previously like project type GUIDs. While capabilities can be defined in the IDE, they make most sense to be directly expressed in the targets themselves where CPS will pick them up automatically. After discussing with @kzu, simply using `Android` could be confusing with native C++ Android project that export the same capability. By combining `Managed + Mobile + Android` we can make a clear distinction that we are dealing with a Xamarin.Android project. [0] https://github.com/microsoft/VSProjectSystem/blob/master/doc/overview/about_project_capabilities.md
pjcollins
added a commit
that referenced
this pull request
Mar 31, 2020
Context: #4383 Visual Studio uses CPS to load SDK-style projects. In CPS, most things are keyed-off so-called capabilities[0] which replace other methods that were used previously like project type GUIDs. While capabilities can be defined in the IDE, they make most sense to be directly expressed in the targets themselves where CPS will pick them up automatically. After discussing with @kzu, simply using `Android` could be confusing with native C++ Android project that export the same capability. By combining `Managed + Mobile + Android` we can make a clear distinction that we are dealing with a Xamarin.Android project. [0] https://github.com/microsoft/VSProjectSystem/blob/master/doc/overview/about_project_capabilities.md
pjcollins
added a commit
that referenced
this pull request
Apr 1, 2020
Context: #4383 Visual Studio uses CPS to load SDK-style projects. In CPS, most things are keyed-off so-called capabilities[0] which replace other methods that were used previously like project type GUIDs. While capabilities can be defined in the IDE, they make most sense to be directly expressed in the targets themselves where CPS will pick them up automatically. After discussing with @kzu, simply using `Android` could be confusing with native C++ Android project that export the same capability. By combining `Managed + Mobile + Android` we can make a clear distinction that we are dealing with a Xamarin.Android project. [0] https://github.com/microsoft/VSProjectSystem/blob/master/doc/overview/about_project_capabilities.md
rolfbjarne
pushed a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jul 6, 2020
Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too.
rolfbjarne
added a commit
to xamarin/xamarin-macios
that referenced
this pull request
Jul 6, 2020
* [.NET 5] Start adding some project capabilities (#3) Aligned with XA too, see dotnet/android#4383. We'll start using Apple instead of iOS for these things at the IDE level since many behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on. These capabilities go before other imports just in case additional packages/targets from the SDK need to access them too. * Remove the LaunchProfiles capability for the CPS integration (#8472) Implements https://work.azdo.io/1112733 as a workaround for the conflicts between the built-in launchsettings.json-based .NET Core debugger and our Mono debugger. Co-authored-by: Daniel Cazzulino <daniel@cazzulino.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio uses CPS to load SDK-style projects. In CPS, most things are keyed-off so-called capabilities[0] which replace other methods that were used previously like project type GUIDs.
While capabilities can be defined in the IDE, they make most sense to be directly expressed in the targets themselves where CPS will pick them up automatically.
[0] https://github.com/microsoft/VSProjectSystem/blob/master/doc/overview/about_project_capabilities.md