Skip to content

Commit

Permalink
[dotnet] Add some project capabilities. (#9013)
Browse files Browse the repository at this point in the history
* [.NET 5] Start adding some project capabilities (#3)

Aligned with XA too, see dotnet/android#4383.

We'll start using Apple instead of iOS for these things at the IDE level since many
behaviors don't actually depend on iOS but also apply to tvOS, watchOS, and so on.

These capabilities go before other imports just in case additional packages/targets
from the SDK need to access them too.

* Remove the LaunchProfiles capability for the CPS integration (#8472)

Implements https://work.azdo.io/1112733 as a workaround for the conflicts between
the built-in launchsettings.json-based .NET Core debugger and our Mono debugger.

Co-authored-by: Daniel Cazzulino <daniel@cazzulino.com>
  • Loading branch information
rolfbjarne and kzu committed Jul 6, 2020
1 parent 31f4a2e commit 9a17e05
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

<!-- Automatically supply project capabilities for IDE use -->
<ItemGroup>
<ProjectCapability Include="Apple" />
<ProjectCapability Include="Mobile" />

<!-- See https://work.azdo.io/1112733 -->
<!-- Conflicts with our targets generator in VS+CPS -->
<ProjectCapability Remove="LaunchProfiles" />
</ItemGroup>

<PropertyGroup>
<_XamarinTaskAssembly Condition="'$(_PlatformName)' != 'macOS'">$(_XamarinSdkRootDirectory)\tools\msbuild\iOS\Xamarin.iOS.Tasks.dll</_XamarinTaskAssembly>
<_XamarinTaskAssembly Condition="'$(_PlatformName)' == 'macOS'">$(_XamarinSdkRootDirectory)\tools\msbuild\macOS\Xamarin.Mac.Tasks.dll</_XamarinTaskAssembly>
Expand Down

7 comments on commit 9a17e05

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed provisioning profiles.

Pipeline on Agent XAMTESTMAC04

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Failed provisioning profiles.

Pipeline on Agent XAMTESTMAC10

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed installing dependencies.

Pipeline on Agent XAMTESTMAC04

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Failed installing dependencies.

Pipeline on Agent XAMTESTMAC10

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (Cambridge) (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

  • Azure DevOps
  • ⚠️ xamarin-storage could not be reached ⚠️

Pipeline on Agent Azure Pipelines 5

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (Cambridge) (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

  • Azure DevOps
  • ⚠️ xamarin-storage could not be reached ⚠️

Pipeline on Agent Azure Pipelines 7

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.