Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpilibc] fix encoder sim docs #6477

Closed
wants to merge 3 commits into from
Closed

[wpilibc] fix encoder sim docs #6477

wants to merge 3 commits into from

Conversation

spacey-sooty
Copy link
Contributor

@spacey-sooty spacey-sooty commented Mar 27, 2024 •
edited
Loading

Resolves #6473

@spacey-sooty spacey-sooty requested a review from a team as a code owner March 27, 2024 03:08
@Gold856
Copy link
Contributor

Gold856 commented Mar 27, 2024

Shouldn't Java be changed instead of C++? The issue said C++ was fine.

@spacey-sooty
Copy link
Contributor Author

Shouldn't Java be changed instead of C++? The issue said C++ was fine.

I might've misread I'll reread it again later today and edit if I was wrong

@chauser
Copy link
Contributor

chauser commented Mar 27, 2024

Yes. #6473 was a Java problem; fixed by PR #6481

@spacey-sooty
Copy link
Contributor Author

whoops

@spacey-sooty spacey-sooty deleted the distancepulse branch March 27, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java EncoderSim.setDistancePerPulse has incorrect parameter name and description
3 participants
@spacey-sooty @Gold856 @chauser