Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java EncoderSim.setDistancePerPulse has incorrect parameter name and description #6473

Closed
chauser opened this issue Mar 26, 2024 · 0 comments · Fixed by #6481
Closed

Java EncoderSim.setDistancePerPulse has incorrect parameter name and description #6473

chauser opened this issue Mar 26, 2024 · 0 comments · Fixed by #6481
Labels
component: wpilibj WPILib Java good first issue Good for newcomers. type: bug Something isn't working.

Comments

@chauser
Copy link
Contributor

chauser commented Mar 26, 2024

The definition of EncoderSim.setDistancePerPulse is

  /**
   * Set the distance per pulse value.
   *
   * @param samplesToAverage the new value
   */
  public void setDistancePerPulse(double samplesToAverage) {
    EncoderDataJNI.setDistancePerPulse(m_index, samplesToAverage);
  }

in Java. It is correct in C++ where the parameter and method are declared

* @param distancePerPulse the new distance per pulse
   */
  void SetDistancePerPulse(double distancePerPulse);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: wpilibj WPILib Java good first issue Good for newcomers. type: bug Something isn't working.
Projects
None yet
2 participants