Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Appium 2 Migration #6276

Merged
merged 62 commits into from
Oct 25, 2023
Merged

Conversation

wpmobilebot
Copy link
Collaborator

@wpmobilebot wpmobilebot commented Oct 11, 2023

Related PRs

What?

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

How?

Tests

Why?

Newer versions of Xcode weren't compatible with Appium 1, so the code needs to be migrated to the latest version to stay up to date with the latest versions available and prevent disruptions in the future with a broken E2E testing environment.

@dcalhoun dcalhoun added Testing Anything related to automated tests [Type] Task labels Oct 11, 2023
WebdriverIO replaces WD for Appium 2 compatability.
Reference new Appium 2 scripts within the Gutenberg repository.
wpmobilebot and others added 7 commits October 12, 2023 13:04
Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
WebdriverIO (the replacement for the deprecated WD driver library) does
not have a method for retrieving a device's pixel ratio. Therefore, this
sets an explicit value for each of our test devices.
There appears to be a small delay before the selection border displays.
It is unclear why this image needs updating. Its sibling iOS image was
updated in:

4346add
Gerardo Pacheco and others added 7 commits October 19, 2023 16:50
…t-gallery-update-util-name

Update Gallery test to use the updated `closeMediaPicker` util
…into version-toolkit/gutenberg/rnmobile/appium-2
Apply the existing Prettier configuration for consistency.
Update for breaking changes from upgrading Appium 2. Reduce verbosity
and duplication between the `WordPress/gutenberg` repository to improve
the approachability and maintainability of the documentation.
dcalhoun and others added 10 commits October 23, 2023 09:16
…ocumentation

docs: Update E2E test documentation
There may be clarity and efficiency by having an explicit setup script.
It was avoid running unnecessary scripts during test runs. It is also
referenced in the current documentation as a script to run
intentionally.
…consistency

test: Improve E2E test consistency
…nd using "npm run test:e2e:bundle:ios" instead.
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a post providing migration details to contributors.

@geriux
Copy link
Contributor

geriux commented Oct 24, 2023

FYI I've pushed this commit ff4d6d4 to revert a change to test:e2e:ios:local since this was recently updated in #6287

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! 🚀

Use of the "Gutenberg for Mobile Apps" name is still under review. In
the meantime, we should use the existing "Mobile Gutenberg" project
name.
@dcalhoun dcalhoun enabled auto-merge October 24, 2023 22:13
…into version-toolkit/gutenberg/rnmobile/appium-2
@dcalhoun dcalhoun merged commit 3f2d6b8 into trunk Oct 25, 2023
@dcalhoun dcalhoun deleted the version-toolkit/gutenberg/rnmobile/appium-2 branch October 25, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants