-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Appium 2 Migration #6276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 11, 2023
Closed
WebdriverIO replaces WD for Appium 2 compatability.
Reference new Appium 2 scripts within the Gutenberg repository.
2 tasks
Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
WebdriverIO (the replacement for the deprecated WD driver library) does not have a method for retrieving a device's pixel ratio. Therefore, this sets an explicit value for each of our test devices.
There appears to be a small delay before the selection border displays.
It is unclear why this image needs updating. Its sibling iOS image was updated in: 4346add
2 tasks
Mirror Android implementation found in Appium 2.
This reverts commit 079b7d6.
…upported-block test: Update Unsupported Block tests for Appium 2
Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
…into version-toolkit/gutenberg/rnmobile/appium-2
2 tasks
…t-gallery-update-util-name Update Gallery test to use the updated `closeMediaPicker` util
…into version-toolkit/gutenberg/rnmobile/appium-2
Apply the existing Prettier configuration for consistency.
Update for breaking changes from upgrading Appium 2. Reduce verbosity and duplication between the `WordPress/gutenberg` repository to improve the approachability and maintainability of the documentation.
2 tasks
…ocumentation docs: Update E2E test documentation
# Conflicts: # gutenberg
There may be clarity and efficiency by having an explicit setup script. It was avoid running unnecessary scripts during test runs. It is also referenced in the current documentation as a script to run intentionally.
…consistency test: Improve E2E test consistency
…nd using "npm run test:e2e:bundle:ios" instead.
dcalhoun
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending a post providing migration details to contributors.
...t-js-gutenberg-editor-test-suite-4-buttons-block-should-allow-edit-text-styles-1-android.png
Show resolved
Hide resolved
geriux
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well! 🚀
Use of the "Gutenberg for Mobile Apps" name is still under review. In the meantime, we should use the existing "Mobile Gutenberg" project name.
…into version-toolkit/gutenberg/rnmobile/appium-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
What?
This PR is generated by
version-toolkit
to downstream the changes forgutenberg
submodule.How?
Tests
Why?
Newer versions of Xcode weren't compatible with Appium 1, so the code needs to be migrated to the latest version to stay up to date with the latest versions available and prevent disruptions in the future with a broken E2E testing environment.