Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gallery test to use the updated closeMediaPicker util #6301

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Oct 19, 2023

Related PRs

What?

This PR updates the Gallery visual test.

Why?

To use the new name for the closePicker util that is now changed to closeMediaPicker.

How?

  • Replaces closePicker to closeMediaPicker

Testing Instructions

Canary tests should succeed in CI.

Local tests should pass by running the following command for both platforms:

Android

 TEST_RN_PLATFORM=android npm run device-tests:local gutenberg-editor-media-blocks-@canary.test

iOS

 TEST_RN_PLATFORM=ios npm run device-tests:local gutenberg-editor-media-blocks-@canary.test

I've also confirmed it runs on SauceLabs by triggering the test from a local command against the Appium 2 build

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the Testing Anything related to automated tests label Oct 19, 2023
@geriux geriux changed the title Update Gallery Test to use the updated closeMediaPicker util Update Gallery test to use the updated closeMediaPicker util Oct 19, 2023
@geriux geriux marked this pull request as ready for review October 19, 2023 13:58
@geriux geriux requested a review from dcalhoun October 19, 2023 13:58
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan succeeded. 🚀

@geriux geriux merged commit 743bb1a into version-toolkit/gutenberg/rnmobile/appium-2 Oct 19, 2023
1 check passed
@geriux geriux deleted the test/functionality-test-gallery-update-util-name branch October 19, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants