Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update Horizontal Layout test for Appium 2 #6284

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Oct 13, 2023

What?

Relates to #6276. Update the Horizontal Layout tests for Appium 2 and
WebdriverIO.

Why?

Improve the stability and quality of the automated tests.

How?

test: Replace sleep with pause
Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.

Testing Instructions

Local tests should pass for the iOS platform when running the following command:

TEST_RN_PLATFORM=ios IPAD=true npm run device-tests:local gutenberg-editor-horizontal-layouts
  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added Testing Anything related to automated tests [Type] Task labels Oct 13, 2023
@dcalhoun dcalhoun self-assigned this Oct 13, 2023
@dcalhoun dcalhoun mentioned this pull request Oct 13, 2023
7 tasks
Base automatically changed from test/appium-update-unsupported-block to version-toolkit/gutenberg/rnmobile/appium-2 October 16, 2023 23:14
Update syntax for WebdriverIO, which is a part of the Appium 2 upgrade.
@dcalhoun dcalhoun force-pushed the test/appium-update-horizontal-layouts branch from a2f86cd to 453f879 Compare October 16, 2023 23:18
@dcalhoun dcalhoun marked this pull request as ready for review October 16, 2023 23:18
@dcalhoun dcalhoun requested review from geriux and removed request for geriux October 16, 2023 23:19
@dcalhoun
Copy link
Member Author

@geriux I am seeing failing tests locally now. I need to resolve those. Apologies for the premature request.

The updated `scrollFromTo` utility resulted in slightly different scroll
positions. This updates the tests and snapshots to account for that.
@dcalhoun dcalhoun requested a review from geriux October 17, 2023 17:15
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The test runs correctly locally and on SauceLabs 🚀

@dcalhoun dcalhoun merged commit d3b7936 into version-toolkit/gutenberg/rnmobile/appium-2 Oct 18, 2023
@dcalhoun dcalhoun deleted the test/appium-update-horizontal-layouts branch October 18, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Anything related to automated tests [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants