Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.39.0 #2713

Merged
merged 95 commits into from
Oct 16, 2020
Merged

Release 1.39.0 #2713

merged 95 commits into from
Oct 16, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Oct 13, 2020 •
edited
Loading

Release for Gutenberg Mobile 1.39.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Known Issues

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Aztec dependencies are pointing to a stable release.
    • iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
  • Gutenberg 'Podfile.lock' inside 'gutenberg/package/react-native-editor/ios/' is updated to the release number.
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

etoledom and others added 30 commits September 23, 2020 15:24
@etoledom
Adding CI check to diffs after running npm install
25f70d9
@etoledom
Add check-diff parameter definition on config.yml
15a7f3a
@etoledom
Fix git diff check script
d2ba256
@etoledom
Update gutenberg ref
1d2fa0b
@etoledom
config.yml: Checksum from gutenberg/package-lock.json
33e2d82 
Instead of local package-lock.json
@etoledom
Using npm install to check package-lock.json diff on PRs
afb3b4b
@etoledom
Fix syntax error on .circleci/config.yml
25063b1
@etoledom
Fix syntax error on .circleci/config.yml
c57cc96
@etoledom
Fix syntax error on .circleci/config.yml
f518bd0
@etoledom
Adding faiulre message option to pFail on bin/ci-checks-js.sh
f74f4c3
@etoledom
bin/ci-checks-js.sh: Removing text coloring.
7e0db8c 
Text color doesn't work on CI machine
@etoledom
CircleCI: Adding cache to npm-install-full command
80884d5
@etoledom
Merge remote-tracking branch 'origin/develop' into test-check-pachage…
0ea29fd 
…-lock-diff
@etoledom
Update gutenberg ref
904d267
@etoledom
Update package-lock.json
4258aa6
@etoledom
Merge remote-tracking branch 'origin/develop' into test-check-pachage…
d777aee 
…-lock-diff
@etoledom
Update ci-checks-js.sh
75984e4
@jd-alexander
Update ref
11a7f68
@jd-alexander
Update ref
0d598d2
Gutenberg ref
5c40419
@mchowning
Clarify that milestones are not required.
6baae40
@jd-alexander
Merge branch 'develop' into issue-2667/android_align_slider_left
15e5306
@jd-alexander
Updated gutenberg ref.
eac5da8
@jd-alexander
Update gutenberg ref.
d283cac
@jd-alexander
Merge branch 'develop' into issue-2657/initial_button_width
71d0886
Bundle update
85480f8
@guarani
Fix image block render in Xcode 12 (#2645)
962d33e 
* Update submodule ref
@etoledom
Merge pull request #2664 from wordpress-mobile/test-check-pachage-loc…
3b58aa6 
…k-diff

Add CI Check for package-lock.json diffs
@etoledom
Implement strings overrides as filters
0667f00
@etoledom
Remove console.logs
acf5502
This was referenced Oct 13, 2020
Merged
Merged
@ceyhun ceyhun mentioned this pull request Oct 13, 2020
Merged
1 task
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 13, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun requested a review from cameronvoell October 15, 2020 12:34
@ceyhun ceyhun marked this pull request as ready for review October 15, 2020 12:34
@ceyhun
Copy link
Contributor Author

ceyhun commented Oct 15, 2020 •
edited
Loading

Testing with WPiOS

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

Tested the changes and extra PRs in the description with WPiOS as well and everything looks good!

@cameronvoell
Copy link
Contributor

Testing with WPAndroid

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

Checks look all good!

cameronvoell
cameronvoell approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all new PRs and everything was working correctly on WPAndroid. Looks good!

@ceyhun
Copy link
Contributor Author

ceyhun commented Oct 16, 2020 •
edited
Loading

Tested with iPhone 11 Pro iOS 14:

DarkMode-1

  • Gallery block - Dark mode - steps
  • Shortcode block - Dark mode - steps
  • Media Text block - Dark mode - steps

Group-1

  • Group - AppenderButton is rendered - steps
  • Group - Deep nesting is possible (iOS only) - steps
  • Group - Check if Group placeholder is visible for the unselected state - steps
  • Group - Check if Group placeholder is render in nested structure - steps
  • Group - Nested block have proper border styling - steps
  • Group - Nested block have proper margins values - steps
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - steps

Spacer-1

  • Spacer block - Spacer is rendered without crash - steps
  • Spacer block - Settings: Control spacer height using the slider - steps
  • Spacer block - Settings: Control spacer height using the text input - steps

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - steps

  • Buttons block - Buttons inline appender - steps

  • Buttons block - Add another Button inside Buttons using inserter - steps

  • Buttons block - Button's wrapper grows properly - steps
    Buttons-2

  • Buttons block - Removing Button along with Buttons block - steps

  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - steps

Buttons-3

  • Buttons block - Wrapping Buttons - steps
  • Buttons block - Buttons alignment options - steps

Button-6

  • Buttons block - Settings: Open in new tab - steps
  • Buttons block - Settings: Link rel - steps
  • Buttons block - Settings: Link URL - steps
  • Buttons block - Settings: Remove link - steps ⚠️ Wasn't able to add a new Link Rel because I couldn't type a space as the iOS keyboard was showing a URL entry keyboard. Issue present on previous version as well, created this: [iOS] Can't add new Link Rel to Button because of wrong keyboard type #2733
  • Buttons block - Settings: Synchronize with button options - steps

Color Settings - 1

  • Colors Segmented Controls - steps
  • Scroll color palette to start - steps
  • Scroll color palette to the end - steps

@ceyhun ceyhun merged commit 9f26157 into trunk Oct 16, 2020
@ceyhun ceyhun deleted the release/1.39.0 branch October 16, 2020 15:55
@enejb
Copy link
Contributor

enejb commented Oct 16, 2020 •
edited
Loading

DarkMode-1

✅ Gallery block - Dark mode
✅ Shortcode block - Dark mode
✅ Media Text block - Dark mode

Group-1

✅ Group - AppenderButton is rendered
✅ Group - Deep nesting is possible (iOS only)
✅ Group - Check if Group placeholder is visible for the unselected state
✅ Group - Check if Group placeholder is render in nested structure
✅ Group - Nested block have proper border styling
✅ Group - Nested block have proper margins values
✅ Group - Breadcrumbs on FloatingToolbar is properly displayed

Spacer-1

✅ Spacer block - Spacer is rendered without crash
✅ Spacer block - Settings: Control spacer height using the slider
✅ Spacer block - Settings: Control spacer height using the text input )

Buttons-1

✅ Buttons block - Buttons block is added with focused Button with gray background color and white text color
✅ Buttons block - Buttons inline appender
✅ Buttons block - Add another Button inside Buttons using inserter
✅ Buttons block - Button's wrapper grows properly

Buttons-2

✅ Buttons block - Removing Button along with Buttons block
✅ Buttons block - Removing exactly one Button (when Buttons contain more of them)

Buttons-3

✅ Buttons block - Wrapping Buttons
✅ Buttons block - Buttons alignment options

Button-6

✅ Buttons block - Settings: Open in new tab
✅ Buttons block - Settings: Link rel
✅ Buttons block - Settings: Link URL
🔴 Buttons block - Settings: Remove link - "Remove link" doesn't exits.
✅ Buttons block - Settings: Synchronize with button options - Not sure if this setting

Color Settings-1

✅ Colors Segmented Controls
✅ Scroll color palette to start
✅ Scroll color palette to the end

@ceyhun ceyhun mentioned this pull request Oct 20, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ceyhun @cameronvoell @enejb @etoledom @jd-alexander @mchowning @guarani @lukewalczak @mzorz @marecar3