Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/2695 ube cannot view or interact with the classic block on jetpack sites #2709

Merged
merged 6 commits into from
Oct 12, 2020
Merged

Fix/2695 ube cannot view or interact with the classic block on jetpack sites #2709

merged 6 commits into from
Oct 12, 2020

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Oct 12, 2020 •
edited
Loading

Fixes #2695

Fellow Gutenberg PR: WordPress/gutenberg#26006

To test:

  1. On the web, create a post with a classic block on a Jetpack site (note: I used Jetpack 9.0.1 WordPress 5.5.1 in this test).
  2. Save or publish the post.
  3. In the app, open the post from the previous step in the block editor.
  4. Tap on the classic block.
  5. Tap on the classic block again.
  6. Select the option to "Edit using the web editor."
  7. Observe that you are able to load or interact with the classic block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@marecar3 marecar3 added this to the 1.39 milestone Oct 12, 2020
@marecar3 marecar3 requested review from guarani and etoledom October 12, 2020 02:20
@marecar3 marecar3 self-assigned this Oct 12, 2020
This was referenced Oct 12, 2020
Merged
Closed
@guarani
Copy link
Contributor

guarani commented Oct 12, 2020

Approved via WordPress/gutenberg#26006 (review)

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 12, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun
Copy link
Contributor

ceyhun commented Oct 12, 2020 •
edited
Loading

@marecar3 We'll be cutting the 1.39 release soon, you have 3 options:

  1. merge the PR as soon as possible
  2. bump the PR to the next milestone
  3. remove the milestone from the PR

@ceyhun ceyhun mentioned this pull request Oct 12, 2020
Merged
5 tasks
@marecar3 marecar3 merged commit 81f3fa8 into develop Oct 12, 2020
@marecar3 marecar3 deleted the fix/2695_UBE_cannot_view_or_interact_with_the_classic_block_on_Jetpack_sites branch October 12, 2020 19:17
@ceyhun ceyhun mentioned this pull request Oct 13, 2020
Merged
5 tasks
@marecar3 marecar3 mentioned this pull request Oct 15, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees

@marecar3 marecar3

Labels
None yet
Projects
None yet
Milestone
1.39
Development

Successfully merging this pull request may close these issues.

Unsupported Block Editor: cannot view or interact with the classic block on Jetpack sites
3 participants
@marecar3 @guarani @ceyhun