Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.39.0 #13119

Merged
merged 11 commits into from
Oct 16, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Oct 13, 2020

Description

This PR incorporates the 1.39.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#2713

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 13, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 13, 2020

You can test the changes on this Pull Request by downloading the APK here.

@ceyhun ceyhun added this to the 16.0 milestone Oct 13, 2020
@ceyhun ceyhun requested a review from cameronvoell October 15, 2020 12:34
@ceyhun ceyhun marked this pull request as ready for review October 15, 2020 12:34
@chipsnyder
Copy link
Contributor

chipsnyder commented Oct 15, 2020

For this release, I'll be running the following sanity tests:
These were all run on a Pixel 3a using this APK

Gallery-1

  • ❌ Gallery block - Close/Re-open post with an ongoing image upload - steps
  • ❌ Gallery block - Close post with an ongoing image upload - steps

Gallery-2

  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps

Gallery-3

  • Gallery block - Add Gallery Caption - steps
  • Gallery block - Add Gallery Image Caption - steps
  • Gallery block - Try adding same images from WP Media library and moving the images around - steps

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - steps
  • Columns - Columns percentage mechanism - column's slider input - steps
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- steps
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- steps
  • Columns - Multiple slider in columns parent - steps
  • Columns - Columns block is added with default number of Column - steps
  • Columns - Adding Column with AppenderButton - steps
  • Columns - Adding and removing Column with BottomSheet Stepper control - steps

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

MediaText-1

  • Media Text block - Insert image from device (failing) - steps
  • ❌ Media Text block - Close/Re-open post with an ongoing image upload - steps

MediaText-2

  • ❌ Media Text block - Insert video from device (cancel) - steps
  • ❌ Media Text block - Insert image from device (cancel) - steps

MultipleUpload-1

  • ❌ Simultaneous uploads - steps

Cover-1

  • Cover - Add image background from WordPress Media library - steps
  • Cover - Change Minimum height in pixels - steps
  • Cover - Change Background Opacity - steps
  • Cover - Image focal point is rendered properly - steps
  • Cover - Custom color is rendered properly - steps

Editor Theme - 1

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - steps
  • Active icon gets product color - steps
  • Only active icons are visible when not selected - steps

Media Errors

For each of the ❌'s on the media upload related tests, there seems to be a permission issue while trying to read images that caused those flows to fail

Error Permissions

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/gutenberg-mobile#2713 (review)

Should be good to go after release is tagged and references are updated 👍

@ceyhun ceyhun merged commit 2476981 into develop Oct 16, 2020
@ceyhun ceyhun deleted the gutenberg/integrate_release_1.39.0 branch October 16, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants