-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Allow easier setting of Featured Image #1011
[Proposal] Allow easier setting of Featured Image #1011
Comments
May I suggest adding the in-content shortcut way as a complementary to the one via the Post Settings? Reason is that via the Post Settings, the user can select any image the image picker can offer (local device, Free Photo Library, taking a new photo, WP Media library), while the in-content shortcut will obviously be for the images already in the post. |
@hypest To be clear, this proposal wasn’t meant to be a replacement for the UI in Post Settings, but as a complimentary piece to better align with user expectations. |
Just making a note of the relevant open issue for the web here: WordPress/gutenberg#13795 @iamthomasbishop, it's mentioned in the comments of that issue that a common error around featured images comes from themes defining specific sizes: How should we account for those errors? |
At @SiobhyB @iamthomasbishop I am looking at the flow here and I have some questions I wanted to ask both of you so I can be on the same page as I will be doing a pair programming session with @SiobhyB to navigate this task. My questions are as follows:
Let me know if my questions are clear or if I need to expound anymore. |
Noting that I did more digging into the We don't currently display this error/notice in the normal flow for setting a featured image within the app and it's not critical i.e. the featured image is still set but some themes simply may not display it on the frontend if it doesn't meet size requirements. It also seems like most newer themes will automatically adapt to the image's size. Although I don't think there's a need to account for this message as a part this PR, the notice does give users a good idea of best standards that may help with search results, I've therefore created enhancement requests for Android here and for iOS here. TL;DR: I don't feel like we need to account for the |
👋 @iamthomasbishop, I wanted to check in with you on the state of this feature so far. From the designs, I saw there was a
The basic "replace" dialog from the mockup is also in place, with a
Does this seem like it's on the right track so far to you? Looking forward to hearing any suggestions or guidance for improvements. :) |
@SiobhyB It makes sense to swap the button for “remove as...” when set, good thinking.
The Dialog looks good, I have a suggestion, but it is beyond scope of the original proposal, so if necessary we can break it off into another ticket: It may be useful in this context to see a small thumbnail of the current featured image on the “replace” Dialog so that you can easily reference it without having to dig through post/page settings. Perhaps it could look similar to how we are showing the focal point on an image on Cover block settings (sans the crosshairs and top-right button):
Is there any way we use the Badge (unsure of proper name?) component here? I thought we were showing it on the top left corner of GIFs, but maybe that’s only on the native Media Library side 🤔. If we don’t have a component for that, we can use what you’ve got here, with one small request: can we round the corners to the same radius as the mover buttons on Gallery images?
Instead of a Snackbar, would it be possible to use the Compact Notice component here? I realize the original idea used a Snackbar, but we’ve since introduced this more compact component. 😀
Definitely, it's looking great! One more small request: can we please add a border at top of the “set as”/“remove as” action button to add some separation? Thanks for the ping, let me know if you have any other questions and/or need further review! |
Thank you for this, @iamthomasbishop! :) I've taken the following actions based on your comment:
|
Reopening as it was inadvertently closed by a PR merge. |
I'm closing this as the new button was added to iOS in #3449 and to Android in WordPress/gutenberg#31705. There are a few outstanding enhancements, but those are tracked in separate issues. |
Problem
The current Featured Image flow has a few issues:
Featured Image is only available in Post Settings screens, which means it can get buried and not easy to locate
If you've set an image from the post body as a Featured Image, it's not obvious which image is selected because there is no visual cue
Solution
To solve the above issues, we should we should supply an intuitive "shortcut" of sorts to achieve this – in context. This could be on the first image of the post, which is typically the image users expect to use.
Add a quick action button to the Image block settings sheet
Add an indicator over the image that is being used as the Featured Image – similar indication that we have on GIFs in Aztec
Optionally, if the Featured Image is already set, we could display a dialog that confirms whether the user wants to replace the current image.
It might look something like this:
Aztec
If we do any work on the Aztec end, I'd recommend we simply add the
Featured
badge to the image that's being used as the Featured Image.The text was updated successfully, but these errors were encountered: