Add Featured Banner to Image Block #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 8, 2021 15:32
This commit points to the relevant PR on Gutenberg.
Revert previous update to .gitmodules, so that it points to the correct WordPress repository.
This commit updates the reference to the latest Gutenberg commit.
SiobhyB
added
[Type] Enhancement
This was referenced Apr 13, 2021
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
👋 @SiobhyB , looking at the diff, the Jetpack submodule seems to get updated too, something I wouldn't expect for this PR. Are there any changes needed on the Jetpack side of things? If not, I'd suggest rewriting the git history to remove the submodule update here. |
|
@hypest, thank you for this note! I've now removed the reference to Jetpack, as you're right that it was committed by accident. |
SiobhyB
force-pushed
the
add-featured-badge
branch
12 times, most recently
from
f81d7b7 to
c4cc7e9
Compare
hypest
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
LGTM!
For visibility, I've left some instructions on how to move forward in WordPress/gutenberg#30806 (review)
SiobhyB
force-pushed
the
add-featured-badge
branch
from
787f247 to
3135669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paritial fix for: #1011
gutenberg: WordPress/gutenberg#30806WordPress-Android: wordpress-mobile/WordPress-Android#14451This PR introduces a Featured banner, which overlays a post's featured image when it's added to an image block. This will make it clear to users which of their images, if any, are set as the post's featured image.
To test: Please refer to the Gutenberg PR as the central place for steps to tests and screenshots.
PR submission checklist: