[RNMobile] Add Featured Banner to Image Block #16332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
[Type] Enhancement
Gutenberg
|
You can trigger an installable build for these changes by visiting CircleCI here. |
This was referenced Apr 19, 2021
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
added 3 commits
April 22, 2021 12:12
This protocol includes a method named didSetFeaturedImage, which will send a message to the JS side when a featured image is set from Post Settings.
SiobhyB
changed the base branch from
develop
to
gutenberg/add/featured-functionality-to-image-block
added 5 commits
April 28, 2021 22:54
… data over the bridge
The intention behind this change is to make the function's purpose clearer. It also moves the naming inline to this feature's Android counterpart. (See: wordpress-mobile/WordPress-Android#14451.)
7 tasks
…eId" This change is a bid align closer to the naming conventions of other functions in iOS.
Generated by 🚫 dangerJS |
SiobhyB
force-pushed
the
gutenberg/add/featured-badge
branch
2 times, most recently
from
3d2cafa to
6d67735
Compare
added 4 commits
April 30, 2021 14:49
This was referenced May 3, 2021
Merged
…to gutenberg/add/featured-badge
…obile/WordPress-iOS into gutenberg/add/featured-badge
illusaen
approved these changes
May 5, 2021
added 2 commits
May 6, 2021 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paritial fix for: wordpress-mobile/gutenberg-mobile#1011
gutenberg: WordPress/gutenberg#31347gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3390This PR introduces a Featured banner on iOS devices, which overlays a post's featured image when it's added to an image block. This will make it clear to users which of their images, if any, are set as the post's featured image.
The main PR for the branch this individual PR will be merged into,
gutenberg/add/featured-functionality-to-image-block-ios, can be found here: #16427To test: Please refer to the Gutenberg PR as the central place for steps to tests and screenshots.
Regression Notes
As this PR adds a banner over the image block, there is some potential for it to unintentionally have a negative impact on the existing UI and/or animations that take place when an image is replaced within the block (depending on whether it's featured or not).
The steps I took to test whether the intended flow works as expected can be found in the linked Gutenberg PR. As this is a UI change, I also tested that the display looks correct in landscape and in dark mode.
No automated tests.
PR submission checklist:
RELEASE-NOTES.txtif necessary.