-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not run clone step if no pipeline step will run #877
Conversation
I improved the "white box" a bit in #846. Maybe that adjustment would be helpful for you in this PR as well. What do you think about hiding empty pipelines and maybe the complete "build" in case they are empty as we are doing a similar thing for pipelines steps which are not executed => they are not shown to the user as well? |
Yeah I thought about this too but wasn't able to implement it after some experiments (I don't know any web frontend dev, which I'd need to add such a weird |
I would: if there are no steps, dont add clone but report success back and only if global pipeline filter #when (#283 ) do filter out make no response |
After the commits I pushed now it just skips and ignores the hook. Should it send a "success" status back and should this always happen for empty builds? |
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
==========================================
- Coverage 51.63% 51.53% -0.11%
==========================================
Files 79 79
Lines 6075 6074 -1
==========================================
- Hits 3137 3130 -7
- Misses 2756 2762 +6
Partials 182 182
Continue to review full report at Codecov.
|
If no steps but pipeline is not filtered golbaly -> success (that way you can still set some pipeline X as required for a pull request, even if a pull dont touch part X of the codebase AND also just define dont report back if) |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some todos ... but that should be covered in another pulls (refactoring etc ...)
Skip the clone step and ignore hook/pipeline if no pipeline step except clone would run. The status reported back to the forge is
success
.Closes #778