Do not run clone step if no pipeline step will run

[qwerty287]

1. Fix empty build link
2. Fix issue if not all builds are skipped

TODO:

• fix the issue Pipelines are skipped where they should not #931

Closes #778

[6543]

I did revert #877 via e2e094c

you can add it back in this pull - it need just more work ...

PS: this patch do not solve the underlaying issue

[6543]

@qwerty287 #949 should make the whole pipeline functions way more readable :)

[qwerty287]

After I tried this for a while, I was finally able to reproduce it and it looks like I found the issue: if a pipeline depends_on another one, but the one it depends on is skipped because it only contains the clone step, the pipeline was marked as "invalid" and removed because this pipeline doesn't occur in the list of pipelines that will run (because it doesn't contain any steps). To fix this, I changed the behavior of what happens if a dependency is missing: don't remove the pipeline completely, but remove the dependency instead and run it anyway. This fixed the issue for me. Is this fine or should it follow the old behavior and the pipeline is skipped? This is harder and requires more code. The current approach would be breaking.

[qwerty287]

I pushed some commits that restore the old handling, but the issue is fixed. I also added a test to test the skipped clone.

[qwerty287]

@woodpecker-ci/Maintainers Would be nice if you could review this PR :)

[6543]

😆 It's still broken :/

[6543]

to reproduce:

1. clone this repo into your local test env
2. enable ci for it
3. change a line in Makefile

expect:

• multible piplenes still run like "docker"
  get:
• only "test" runn and report build successfull

[6543]

at some point I'll also have a look at this ... as I dislike how global pipeline filter do (internaly) work atm

[anbraten]

I had a look and debugged it as well a few days / maybe even weeks ago (sorry for that). I also experienced some issues with it while testing. In general this is pretty related to #770 and I would like to have a more generic way of checking dependencies and if a required pipeline (depends_on) failed / is existing at all. Having properties like isEmpty / skippedClone sounds a bit to specific to me right now 🙈

[qwerty287]

So just close this and fix it later?

[anbraten]

Okay lets write down the cases again as I am not sure how you planned on handling each specific:

• pipeline is required by depends_on, but hasn't been defined at all (typo, not added yet) => the config is marked as wrong by the linter?!
• pipeline is required by depends_on, but was skipped as it was empty / only clone steps => treat as successful
• pipeline is required by depends_on, but was skipped as it hasn't matched root.when Add support for pipeline root.when conditions #770) => skip dependent pipelines as well
• pipeline is required by depends_on, but was failing => stop pipeline execution and skip dependent pipelines
• pipeline is required by depends_on and was successful => go on

[qwerty287]

pipeline is required by depends_on, but hasn't been defined at all (typo, not added yet) => the config is marked as wrong by the linter?!

The corresponding depends_on is ignored completely, not sure if the linter says something.

pipeline is required by depends_on, but was skipped as it was empty / only clone steps => treat as successful?

Yes, treated as successful.

pipeline is required by depends_on, but was skipped as it hasn't matched root.when
#770) => skip dependent pipelines or treat as successful?

Dependent pipelines are skipped as well.

[anbraten]

Nice. I have updated my comment.

The corresponding depends_on is ignored completely, not sure if the linter says something.

I just checked it. The linter is not checking that a depends_on target pipeline exists, but I think that would be a helpful additional feature for another PR.

[qwerty287]

I'm going to close this. If somebody refactors the pipeline compiling, it would be good to look into this again.