Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xterm.js for log outputs #846

Merged
merged 18 commits into from
Jun 16, 2022
Merged

Use xterm.js for log outputs #846

merged 18 commits into from
Jun 16, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Mar 23, 2022

closes #718
closes #768
closes #776
solves parts of #721

Fixes

  • flickering when adding new log-lines while step is running

@anbraten anbraten added ui frontend related enhancement improve existing features labels Mar 23, 2022
@anbraten anbraten requested a review from 6543 March 23, 2022 13:49
@6543
Copy link
Member

6543 commented Mar 23, 2022

downside: log line numbers are gone

@anbraten
Copy link
Member Author

downside: log line numbers are gone

and the time on the right. Maybe we could create a xterm.js plugin to get this functionality back in the long term

@6543 6543 added this to the 1.0.0 milestone Apr 5, 2022
@6543
Copy link
Member

6543 commented May 9, 2022

... we could create a xterm.js plugin ...

I think we should do this first :)

@x80486
Copy link

x80486 commented Jun 3, 2022

I was sniffing on the Xterm.js issue tracker and sort of make sense that this data should be handled outside of the library. I guess a couple of functions will do it as well.

There is an example on the aforementioned issue.

@anbraten
Copy link
Member Author

anbraten commented Jun 3, 2022

I added the loglines similar to the suggestion from the xterm issue. Not super happy with their styling, but I think its fine like that for now.

Screenshot from 2022-06-03 18-17-59

@qwerty287
Copy link
Contributor

Code looks good, but didn't test it.

@6543
Copy link
Member

6543 commented Jun 10, 2022

I'm going to test it today

@6543
Copy link
Member

6543 commented Jun 11, 2022

https://cloud.obermui.de/s/RZg582XmKG4SN48

the background coloring has some strange relicts
and switching light-/dark-mode do result in unpredictable behavior :/

@6543
Copy link
Member

6543 commented Jun 11, 2022

and switching lgitht/dark-mode do result in unpredictable behaviour :/

@anbraten
Copy link
Member Author

Seems to work for me. Maybe browser related I would do a follow-up in that case if that is fine for you.

screencast.mp4

@6543
Copy link
Member

6543 commented Jun 16, 2022

great work 🚀 i would say - finally :)

@6543 6543 merged commit 3c4d451 into woodpecker-ci:master Jun 16, 2022
@anbraten anbraten deleted the xterm branch June 16, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features ui frontend related
Projects
None yet
4 participants