Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cut / tail very long logs #776

Closed
anbraten opened this issue Feb 11, 2022 · 1 comment · Fixed by #846
Closed

cut / tail very long logs #776

anbraten opened this issue Feb 11, 2022 · 1 comment · Fixed by #846
Labels
enhancement improve existing features

Comments

@anbraten
Copy link
Member

We currently send all log data at once to the client. In the case a job generated a lot of logs we should for example think about just sending the last 500 lines of logs otherwise the browser tab will OOM when dealing with that much data. Chunking will probably not help in this case as well as the browser would have to load that data in memory. Maybe we can set a limit by default for the api endpoint and allow to download / receive the whole data (#566) when a parameter is applied.

@anbraten anbraten added the enhancement improve existing features label Feb 11, 2022
@xuecanlong
Copy link
Contributor

can we save log into s3 when job be done? then server can just access s3 log file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants