Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ipv6 addresses in constructor string #113

Closed
wanderview opened this issue Sep 1, 2021 · 0 comments
Closed

Support ipv6 addresses in constructor string #113

wanderview opened this issue Sep 1, 2021 · 0 comments

Comments

@wanderview
Copy link
Member

As pointed out in #110 its not possible to do new URLPattern("http://[::1]/"). Even if you properly escape the colons like new URLPattern("http://[\\:\\:1]/") it still throws.

Adding support for this turns out to not be too hard. The URL spec simply ignores colons inside [ ] brackets. We can do the same in URLPattern. Of course, for the hostname pattern to be valid the colon's will still need to be escaped.
@wanderview wanderview mentioned this issue Sep 1, 2021
Closed
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 1, 2021
@wanderview @chromium-wpt-export-bot
URLPattern: Support constructor strings with ipv6 addresses.
61a2451 
This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
@wanderview wanderview mentioned this issue Sep 1, 2021
Merged
@wanderview wanderview mentioned this issue Sep 2, 2021
Closed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 2, 2021
@wanderview @chromium-wpt-export-bot
URLPattern: Support constructor strings with ipv6 addresses.
67015a5 
This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 2, 2021
@wanderview @chromium-wpt-export-bot
URLPattern: Support constructor strings with ipv6 addresses.
8bd7648 
This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Sep 2, 2021
@wanderview @chromium-wpt-export-bot
URLPattern: Support constructor strings with ipv6 addresses.
4a8e1e0 
This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}
pull bot pushed a commit to FairyWorld/tool_chromium that referenced this issue Sep 2, 2021
@wanderview
URLPattern: Support constructor strings with ipv6 addresses.
43dcc53 
This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 4, 2021
@wanderview @moz-wptsync-bot
Bug 1728654 [wpt PR 30290] - URLPattern: Support constructor strings …
151d54d 
…with ipv6 addresses., a=testonly

Automatic update from web-platform-tests
URLPattern: Support constructor strings with ipv6 addresses.

This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}

--

wpt-commits: 4a8e1e081701c95a7f2d27eff2d2a9ee96691edc
wpt-pr: 30290
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 5, 2021
@wanderview @moz-wptsync-bot
Bug 1728654 [wpt PR 30290] - URLPattern: Support constructor strings …
5f0f0a5 
…with ipv6 addresses., a=testonly

Automatic update from web-platform-tests
URLPattern: Support constructor strings with ipv6 addresses.

This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}

--

wpt-commits: 4a8e1e081701c95a7f2d27eff2d2a9ee96691edc
wpt-pr: 30290
spinda pushed a commit to PLSysSec/cachet-firefox that referenced this issue Sep 8, 2021
@wanderview @moz-wptsync-bot
Bug 1728654 [wpt PR 30290] - URLPattern: Support constructor strings …
ef17ca6 
…with ipv6 addresses., a=testonly

Automatic update from web-platform-tests
URLPattern: Support constructor strings with ipv6 addresses.

This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}

--

wpt-commits: 4a8e1e081701c95a7f2d27eff2d2a9ee96691edc
wpt-pr: 30290
spinda pushed a commit to PLSysSec/cachet-firefox that referenced this issue Sep 8, 2021
@wanderview @moz-wptsync-bot
Bug 1728654 [wpt PR 30290] - URLPattern: Support constructor strings …
5aa8429 
…with ipv6 addresses., a=testonly

Automatic update from web-platform-tests
URLPattern: Support constructor strings with ipv6 addresses.

This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}

--

wpt-commits: 4a8e1e081701c95a7f2d27eff2d2a9ee96691edc
wpt-pr: 30290
wanderview added a commit to wanderview/urlpattern-polyfill that referenced this issue Jan 6, 2022
@wanderview
Support constructor strings with ipv6 addresses. (kenchris#37)
7b77ab9 
This commit includes change to address both:

whatwg/urlpattern#113
whatwg/urlpattern#115
@wanderview wanderview mentioned this issue Jan 6, 2022
Merged
kenchris pushed a commit to kenchris/urlpattern-polyfill that referenced this issue Jan 6, 2022
@wanderview @kenchris
Support constructor strings with ipv6 addresses. (#37)
ae7fc69 
This commit includes change to address both:

whatwg/urlpattern#113
whatwg/urlpattern#115
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@wanderview @copybara-github
URLPattern: Support constructor strings with ipv6 addresses.
39fd7cb 
This adds support for constructor strings like:

  new URLPattern("http://[\\:\\:1]/");

As discussed in spec issue #113:

  whatwg/urlpattern#113

Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}
NOKEYCHECK=True
GitOrigin-RevId: 43dcc539848d97c60cd01772b061d920c828c089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wanderview