URLPattern: Support constructor strings with ipv6 addresses. #30290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 1, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3138336
branch
from
61a2451
to
67015a5
Compare
This adds support for constructor strings like:
new URLPattern("http://[\\:\\:1]/");
As discussed in spec issue #113:
whatwg/urlpattern#113
Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3138336
branch
from
67015a5
to
8bd7648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for constructor strings like:
new URLPattern("http://[\:\:1]/");
As discussed in spec issue #113:
whatwg/urlpattern#113
Fixed: 1245760
Change-Id: I712341e72a5c2af745dbbdbb8673a79809a98425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138336
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/main@{#917682}