Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site) Add v3 docs to deployment #1992

Closed
wants to merge 1 commit into from
Closed

Conversation

montogeek
Copy link
Member

Added v3 docs to deploy script by git checking fix/v3-docs branch which have necessary changes to make site works under a subfolder and also last v3 docs.

@montogeek
Copy link
Member Author

@jeremenichelli Could you please review this one?

@montogeek montogeek requested a review from jeremenichelli April 7, 2018 06:33
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right approach. Each branch should build on its own. On deploy you should just make sure to don't delete the other output.

@montogeek
Copy link
Member Author

@sokra gh-pages command doesn't support excluding directories.
My changes only apply to deployment, PRs and other branches only run build and test.

There is no other output for v3 docs, they have to be build from fix/v3-docs branch, which contains specific changes to make website work in a subfolder.

I already tried to preserve previous files #1972, but it won't work because any our file names doesn't change, if we add new docs to a page they won't be updated.

@kirkobyte
Copy link

Could be good to take @sokra's suggestion by creating a webpack-3 branch off the 3.11.0 tag. I'd do so myself but I don't have permissions to create a branch.
Then you could modify this build to create v3/ on merge into webpack-3

@JaKXz
Copy link

JaKXz commented Jun 13, 2018

Is there anything I can do to help get this merged?

@JaKXz
Copy link

JaKXz commented Jul 16, 2018

Would it be possible to merge this as a temporary measure while the infrastructure for v3 is figured out?

@montogeek
Copy link
Member Author

Closing in favour of a better solution.

@montogeek montogeek closed this Jan 6, 2019
@montogeek montogeek deleted the feat/deploy-v3-docs branch January 6, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants