-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(site) Add v3 docs to deployment #1992
Conversation
@jeremenichelli Could you please review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the right approach. Each branch should build on its own. On deploy you should just make sure to don't delete the other output.
@sokra There is no other output for v3 docs, they have to be build from I already tried to preserve previous files #1972, but it won't work because any our file names doesn't change, if we add new docs to a page they won't be updated. |
Could be good to take @sokra's suggestion by creating a |
Is there anything I can do to help get this merged? |
Would it be possible to merge this as a temporary measure while the infrastructure for v3 is figured out? |
Closing in favour of a better solution. |
Added v3 docs to deploy script by git checking
fix/v3-docs
branch which have necessary changes to make site works under a subfolder and also last v3 docs.