chore(rebuild): finish navigation refactoring #2048
Conversation
| ...links, | ||
| { | ||
| title: 'GitHub Repository', | ||
| url: '//github.com/webpack/webpack', |
There was a problem hiding this comment.
this will always result in https as gh pages forcing https, maybe type https explicitly here too like for the other urls below?
There was a problem hiding this comment.
Will do, I think this was an artifact from a while back.
src/components/Site/Site.jsx
Outdated
| { title: 'Blog', url: '//medium.com/webpack' } | ||
| { content: 'Contribute', url: '/contribute' }, | ||
| { content: 'Vote', url: '/vote' }, | ||
| { content: 'Blog', url: '//medium.com/webpack' } |
| @@ -62,16 +62,16 @@ class Site extends React.Component { | |||
| toggleSidebar={ this._toggleSidebar } | |||
| links={[ | |||
| { | |||
| title: 'Documentation', | |||
| content: 'Documentation', | |||
| url: '/concepts', | |||
There was a problem hiding this comment.
We need to rethink how URLs are formed, when trying to build the site to work under a path I had to do a lot of changes (https://github.com/webpack/webpack.js.org/tree/fix/v3-docs), we need to work on it now in order to be able to support multiple versions in the future
There was a problem hiding this comment.
Yeah that's definitely something we need to tackle at some point, but is that something that needs to happen before rebuild is merged? Will these routes conflict with the /v3 route you created?
Personally I think figure out version management as a follow up after finishing rebuild (though I understand we did need to get something up quickly before for v3 when deploying v4).
There was a problem hiding this comment.
this is indeed a pain point for community, though lets try to keep it to the plan and get rebuild into master asap before diving into much detail on doc versioning
There was a problem hiding this comment.
No, after merging rebuild is fine, would be better to do it before so we can launch new website with multiple versions support, that would make headlines! (jk).
I have tried to push that change, without success #1992 :/
skipjack
changed the title
Ideally we should still move away from the icon font but this fixes some issues with the font's vertical metrics due to different svg sizing.
…on links The `next` version of `react-banner` supports more generic `items` rather than focusing solely on `links` which customizations like icons and dropdowns much easier to handle.
skipjack
force-pushed
the
rebuild-navigation
branch
from
3dc27e9 to
d9fc15b
Compare
|
I can help out finding any links that are of the wrong form with assetgraph. There's a bit of extra work bridging the Gap back to the markdown file, but I'm sure we can script that |
| import DocSearch from 'docsearch.js'; | ||
|
|
||
| // Import Utilities/Images | ||
| import GitHubIcon from '../../styles/icons/github.svg'; |
There was a problem hiding this comment.
Is this dependency used? I can't spot it. I'm seeing we are using the class for the icon font instead.
There was a problem hiding this comment.
Good catch, I’ll remove it. Played around with it momentarily and the fixed font metrics instead.
Re-integrate icon links and searching in the navigation bar. Use the
nextversion ofreact-bannerwhich supports more generic banner items.