Show error overlay even after browser refresh #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
glenjamin
reviewed
Oct 5, 2016
|
@glenjamin I think it's actually desirable to have the rest of the hot reloading code run because as soon as you fix the error it'll just continue as if you hadn't ever refreshed. I'll tidy it up and try to ensure I cover any potential edge cases. |
richardscarrott
changed the title
1 similar comment
|
@glenjamin I've tidied it up with the following improvements:
Let me know your thoughts. |
glenjamin
reviewed
Oct 5, 2016
| sinon.assert.calledOnce(processUpdate); | ||
| it("should trigger webpack on successful builds / syncs", function() { | ||
| const actions = ['built', 'sync']; | ||
| actions.forEach(function(action) { |
There was a problem hiding this comment.
Could you move this loop outside the it(), or manually repeat the test so that it's two distinct cases?
|
@glenjamin 👍 let me know when you next publish |
|
Released as |
joshwiens
pushed a commit
that referenced
this pull request
Mar 30, 2018
* Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh
joshwiens
pushed a commit
that referenced
this pull request
Mar 30, 2018
* Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh * fixup! Show error overlay even after browser refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you refresh the client whilst the compilation is in an error state you don't get any feedback (and if using the NoErrorsPlugin you actually get a working app; albeit using the last working bundle) -- you need to check the terminal window to be sure this hasn't happened.
This PR aims to solve the problem by publishing the 'built' event based on the last known compilation stats as soon as a client is registered with the middleware meaning the client script will show the overlay if appropriate.