Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the error overlay on page refresh #133

Closed
calesce opened this issue Oct 9, 2016 · 2 comments
Closed

Show the error overlay on page refresh #133

calesce opened this issue Oct 9, 2016 · 2 comments

Comments

@calesce
Copy link

calesce commented Oct 9, 2016

Continuing the discussion from gaearon/react-hot-loader#390:

It can sometimes be confusing when you don't see the overlay after refreshing, because you'll be working with the most recent valid webpack build without knowing that there's still an unresolved error until you look back at the console.

I tested with create-react-app, and their overlay appears on refresh (relevant code seems to be here), so that solution might be applicable here.

I'll be happy to do the PR for this if people agree this is a good idea.

@glenjamin
Copy link
Collaborator

I think this is what #132 does.

It'll be in the next release - which should be in the next day or two.

@calesce
Copy link
Author

calesce commented Oct 9, 2016

Should've looked harder, thanks!

@calesce calesce closed this as completed Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants