-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates no longer working after fixing syntax error #390
Comments
Hi, you can continue the conversation in the same issues after it's closed. Can you provide a simple repository that reproduces the issue? If you want to see a working examples you can look here. |
Hi I've tried the example you have linked to. That also has the same problem. I edited one of the components. Added a syntax error. Any changes after that are no longer picked up until you refresh. thanks |
Syntax error or runtime exception? Have an example? RHL isn't able to recover from errors on updates to |
Added the following error class Home extends Component { Hello, world ;} } |
@aoshi321: OK, yeah if you refresh after Webpack fails to build, you won't see the error overlay in the browser, just the console. The overlay only appears in hot updates. I can see how that's confusing. It might be worth opening an issue with |
Interesting question. It might be possible to load only the overlay, although there isn't an obvious way to get a working webpack build to do that when the intended one is broken. If we found a way to load a stub with an overlay, I'm not sure whether it could be hot reloaded back into the main application. |
Ok, opened as webpack-contrib/webpack-hot-middleware#133, thanks for responding @glenjamin! Closing this one because it's not specific to RHL. |
Hi
In regards to the closed issue #389 and I am using webpack-dev-middleware/webpack-hot-middleware and I'm still experiencing the same issue.
thanks
Aoshi
The text was updated successfully, but these errors were encountered: