Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates no longer working after fixing syntax error #390

Closed
aoshi321 opened this issue Oct 4, 2016 · 7 comments
Closed

Updates no longer working after fixing syntax error #390

aoshi321 opened this issue Oct 4, 2016 · 7 comments

Comments

@aoshi321
Copy link

aoshi321 commented Oct 4, 2016

Hi

In regards to the closed issue #389 and I am using webpack-dev-middleware/webpack-hot-middleware and I'm still experiencing the same issue.

thanks

Aoshi

@calesce
Copy link
Collaborator

calesce commented Oct 4, 2016

Hi, you can continue the conversation in the same issues after it's closed. Can you provide a simple repository that reproduces the issue? If you want to see a working examples you can look here.

@aoshi321
Copy link
Author

aoshi321 commented Oct 4, 2016

Hi

I've tried the example you have linked to. That also has the same problem. I edited one of the components. Added a syntax error. Any changes after that are no longer picked up until you refresh.

thanks

@calesce
Copy link
Collaborator

calesce commented Oct 4, 2016

Syntax error or runtime exception? Have an example? RHL isn't able to recover from errors on updates to render, see #164.

@aoshi321
Copy link
Author

aoshi321 commented Oct 4, 2016

Added the following error

class Home extends Component {
render() { £$%£$%£$
return

Hello, world
;
}
}

@calesce
Copy link
Collaborator

calesce commented Oct 4, 2016

@aoshi321: OK, yeah if you refresh after Webpack fails to build, you won't see the error overlay in the browser, just the console. The overlay only appears in hot updates. I can see how that's confusing.

It might be worth opening an issue with webpack-hot-middleware to get the syntax error overlay on page refresh (if it's possible/feasible), what would you think @glenjamin?

@glenjamin
Copy link

Interesting question.

It might be possible to load only the overlay, although there isn't an obvious way to get a working webpack build to do that when the intended one is broken.

If we found a way to load a stub with an overlay, I'm not sure whether it could be hot reloaded back into the main application.

@calesce
Copy link
Collaborator

calesce commented Oct 9, 2016

Ok, opened as webpack-contrib/webpack-hot-middleware#133, thanks for responding @glenjamin!

Closing this one because it's not specific to RHL.

@calesce calesce closed this as completed Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants