Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to close the overlay #136

Open
mgol opened this issue Oct 25, 2016 · 2 comments
Open

Allow to close the overlay #136

mgol opened this issue Oct 25, 2016 · 2 comments

Comments

@mgol
Copy link

mgol commented Oct 25, 2016

The DOM-based error overlay is a nice feature but sometimes I need to fire up code with linting errors just for a moment and the overlay blocks access to the page. Up until now I was just refreshing the page in such a case but after PR #132 was landed it stopped being possible.

How about a Close button in a corner that would close the overlay when clicked? The overlay should return on the next HMR update.

@glenjamin
Copy link
Collaborator

My personal approach to this is to not have linting be part of the webpack build, I only run it on the cli, in my editor, or on the CI server.

Another option would be to have the lint checks at "warning" level, as the overlay doesn't appear for warnings (they're only reported in the console).

That said, having a way to dismiss the overlay seems reasonable to me, so I'd take a PR which added a close button.

@mgol
Copy link
Author

mgol commented Oct 25, 2016

OK, I'll dive into it tomorrow then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants