This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Release/1.3.5 #3974
Merged
Release/1.3.5 #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://web3-js-pr-3974.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c1d9lplua9vondbnpdc0. |
|
Replicating the steps mentioned in previous releases As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.
(This list will be actively edited)
Synthetic tests failed with same Protocol tests failed with (using the latest @uma/financial-templates-lib: 606 passing (38m)
@uma/financial-templates-lib: 4 failing
@uma/financial-templates-lib: 1) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib: Basic historical price:
@uma/financial-templates-lib: Error: TraderMade-test-pair: time 1611626300 is before firstPriceTime.openTime
@uma/financial-templates-lib: at TraderMadePriceFeed.getHistoricalPrice (src/price-feed/TraderMadePriceFeed.js:125:13)
@uma/financial-templates-lib: at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:114:34)
@uma/financial-templates-lib: at runMicrotasks (<anonymous>)
@uma/financial-templates-lib: at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib: 2) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib: apiKey present:
@uma/financial-templates-lib: AssertionError: expected [ Array(3) ] to deeply equal [ Array(3) ]
@uma/financial-templates-lib: + expected - actual
@uma/financial-templates-lib: [
@uma/financial-templates-lib: - "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-23-22:00&end_date=2021-02-25-22:43&format=records&interval=hourly"
@uma/financial-templates-lib: - "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-25-22:30&end_date=2021-02-25-22:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib: + "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-24-04:00&end_date=2021-02-26-04:43&format=records&interval=hourly"
@uma/financial-templates-lib: + "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=test-api-key&start_date=2021-02-26-04:30&end_date=2021-02-26-04:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib: "https://marketdata.tradermade.com/api/v1/live?currency=test-pair&api_key=test-api-key"
@uma/financial-templates-lib: ]
@uma/financial-templates-lib:
@uma/financial-templates-lib: at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:499:12)
@uma/financial-templates-lib: at runMicrotasks (<anonymous>)
@uma/financial-templates-lib: at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib: 3) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib: apiKey absent:
@uma/financial-templates-lib: AssertionError: expected [ Array(3) ] to deeply equal [ Array(3) ]
@uma/financial-templates-lib: + expected - actual
@uma/financial-templates-lib: [
@uma/financial-templates-lib: - "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-23-22:00&end_date=2021-02-25-22:43&format=records&interval=hourly"
@uma/financial-templates-lib: - "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-25-22:30&end_date=2021-02-25-22:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib: + "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-24-04:00&end_date=2021-02-26-04:43&format=records&interval=hourly"
@uma/financial-templates-lib: + "https://marketdata.tradermade.com/api/v1/timeseries?currency=test-pair&api_key=undefined&start_date=2021-02-26-04:30&end_date=2021-02-26-04:43&format=records&interval=minute&period=10"
@uma/financial-templates-lib: "https://marketdata.tradermade.com/api/v1/live?currency=test-pair&api_key=undefined"
@uma/financial-templates-lib: ]
@uma/financial-templates-lib:
@uma/financial-templates-lib: at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:512:12)
@uma/financial-templates-lib: at runMicrotasks (<anonymous>)
@uma/financial-templates-lib: at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib: 4) Contract: TraderMadePriceFeed.js
@uma/financial-templates-lib: Hourly interval can act as historical price fallback for minute interval
@uma/financial-templates-lib: Fallback to hourly interval ENABLED, failure to fetch minute interval successfully fetches hourly data:
@uma/financial-templates-lib: Error: TraderMade-test-pair: time 1611626300 is before firstPriceTime.openTime
@uma/financial-templates-lib: at TraderMadePriceFeed.getHistoricalPrice (src/price-feed/TraderMadePriceFeed.js:125:13)
@uma/financial-templates-lib: at Context.<anonymous> (test/price-feed/TraderMadePriceFeed.js:239:36)
@uma/financial-templates-lib: at runMicrotasks (<anonymous>)
@uma/financial-templates-lib: at processTicksAndRejections (internal/process/task_queues.js:93:5)
@uma/financial-templates-lib: error Command failed with exit code 4.
@uma/financial-templates-lib: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run test exited 4 in '@uma/financial-templates-lib'
error Command failed with exit code 4. |
Pull Request Test Coverage Report for Build 720258403
💛 - Coveralls |
spacesailor24
added a commit
that referenced
this pull request
Jul 2, 2021
* Release/1.3.5 (#3974) * Update changelog * Built dist * Update version numbers * v1.3.5 Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal> * Bump underscore (#4051) * bump underscore * update package-locks * bump lcoks again * Release 1.3.6 (#4053) * Update CHANGELOG and ran npm i * Built lib for 1.3.6-rc.0 * v1.3.6-rc.0 * npm i * Built lib for 1.3.6-rc.1 * v1.3.6-rc.1 * 1.3.6-rc.2 (#4059) * npm i && npm audit fix * Manually bump version to 1.3.6-rc.2 * Built lib for 1.3.6-rc.2 * v1.3.6-rc.2 * 1.3.6-rc.2 fixes (#4062) * Manually update dependency versions to 1.3.6-rc.2 * Accidental commit * npm i * Manually update web3 dependency version to 1.3.6-rc.2 * npm i * Built manually for 1.3.6-rc.2 * Update CHANGELOG * Update CHANGELOG.md Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> * Add web3-core-helpers as dev dependency * Add web3-core-helpers as dev dependency * Fixing 1.3.6-rc.2 related issues (#4063) * Remove web3-eth-ens as dependency * Regen package-locks and build lib * Remove dtslint from ci scripts (#4064) * Remove web3-eth-ens as dependency * Regen package-locks and build lib * Remove npm run dtslint from build and lint * 1.3.6-rc.2 Fixes (#4065) * Remove web3-eth-ens as dependency * Regen package-locks and build lib * Remove npm run dtslint from build and lint * Add back removed package: web3-eth-ens * npm i * Build lib * Add back npm run dtslint * Update geth-dev-assistant * v1.3.6 Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> * Add unsubscribeByID (#4061) * adding function unsubscribe by id * adding an unsubscribe testcase * adding testcase * seperated unsubscribebyid to its own method * adding testcases * adding await * fixing testcases Co-authored-by: Alex <alex.luu@mail.utoronto.ca> Co-authored-by: Alex <alex@chainsafe.io> * ignore .md and docs (#4077) * adding berlin tx support (#4109) * add berlin tx support * update install locations * update package name in comment * fix existing tests to support new tx sigining format * remove build * remove old test case * use latest ethereumjs/tx * bump deps and fix test * update hashes * fix messageHash, decoding bug * fix tests * add hack * adding eip2930 and common object * fix lint updating package-lock * fix berlin tx signing and recovery * updating ethereumjs/tx package * updating checksum * removing helper.js * updating changelog and docs * fixing typo Co-authored-by: Gregory Markou <gregorymarkou@gmail.com> * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth (#4154) * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth * Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth * Fix typo * Release v1.4.0 (#4118) * npm run build for 1.4.0-rc.0 * v1.4.0-rc.0 * 1.4.0 Geth version downgrade (#4149) * Update pull Geth docker version from stable to pre-london (1.10.3) * Update CHANGELOG * v1.4.0 Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal> Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca> Co-authored-by: Alex <alex@chainsafe.io> Co-authored-by: Gregory Markou <gregorymarkou@gmail.com>
spacesailor24
added a commit
that referenced
this pull request
Jul 27, 2021
* Update changelog * Built dist * Update version numbers * v1.3.5 Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal>
spacesailor24
added a commit
that referenced
this pull request
Jul 28, 2021
* Release/1.3.5 (#3974) * Update changelog * Built dist * Update version numbers * v1.3.5 Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal> * Merge conflicts * Merge conflicts * Add unsubscribeByID (#4061) * adding function unsubscribe by id * adding an unsubscribe testcase * adding testcase * seperated unsubscribebyid to its own method * adding testcases * adding await * fixing testcases Co-authored-by: Alex <alex.luu@mail.utoronto.ca> Co-authored-by: Alex <alex@chainsafe.io> * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Merge conflicts * Update CHANGELOG (#4193) Test don't run when only changes to `CHANGELOG.md` have been made Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal> Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com> Co-authored-by: Alex <alex.luu@mail.utoronto.ca> Co-authored-by: Alex <alex@chainsafe.io>
|
Ok |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
web3-eth2-coreandweb3-eth2-beaconchainpackages (Add eth2 github action #3892)web3.utils.soliditySha3(Update soliditySha3 docs #3908).nvmrcfile using Node.js versionv.14.15.1(add nvmrc file #3817)1.3.0and onwards (Debugging failing test #3961)Changed
web3-eth2-coreandweb3-eth2-beaconchain(Add eth2 github action #3892)tscscript in all packages tocompile; updates the correspondinglerna runusage in the mainpackage.json(Update tsc npm command to compile #3894)@chainsafe/geth-dev-assistantfrom0.1.5to0.1.9(Merging geth-dev-assistant updates #3950)ellipticfrom6.5.3to6.5.4forweb3-eth-accounts(Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-eth-accounts #3941)ellipticfrom6.5.3to6.5.4forweb3-bzz(Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz #3940)ellipticfrom6.5.3to6.5.4forweb3-core-requestmanager(Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager #3945)web3-eth-ibanin ES6 (Rewrite web3-eth-iban #3955)