Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 1.2.10 #3633

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Release - 1.2.10 #3633

merged 3 commits into from
Jul 17, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Jul 9, 2020

This PR introduces web3.js version 1.2.10 beginning with 1.2.10-rc.0.

Please see the release notes for more.

Changelog

Added

Changed

Fixed

Compare View

v1.2.9 -> v1.2.10

Type of change

  • Release

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@ryanio ryanio added Release 1.x 1.0 related issues labels Jul 9, 2020
@coveralls
Copy link

coveralls commented Jul 9, 2020

Coverage Status

Coverage remained the same at 90.254% when pulling 6c2357b on release/1.2.10 into 6862c59 on 1.x.

@cgewecke
Copy link
Collaborator

cgewecke commented Jul 9, 2020

As part of the RC process, am doing some test installations in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@cgewecke
Copy link
Collaborator

Incidental to this release... while running the Synthetix tests, believe I found another difference between old and new Ethers.

Beginning with Web3 1.2.8, ABI decoded array return values are immutable.

// Solidity
function getAddresses() returns (address[] addrs){
  ...
}

// JS
const immutableArray = await instance.methods.getAddresses().call();

Applying native .sort directly on the return value now throws an error like:

TypeError: Cannot assign to read only property '1' of object '[object Array]'
      at Array.sort (native)
      at Context.it.only (test/contracts/BinaryOptionMarketManager.js:859:60)
      at process._tickCallback (internal/process/next_tick.js:68:7)

...because it tries to sort in place.

A work-around is to copy the array: e.g.

const sorted = [...immutableArray].sort()`.

Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ryanio ryanio merged commit 111cca3 into 1.x Jul 17, 2020
@GregTheGreek GregTheGreek deleted the release/1.2.10 branch July 26, 2020 04:15
@spacesailor24 spacesailor24 mentioned this pull request Sep 2, 2020
14 tasks
@spacesailor24 spacesailor24 mentioned this pull request Oct 23, 2020
This was referenced Jan 21, 2021
This was referenced Mar 23, 2021
@spacesailor24 spacesailor24 mentioned this pull request May 14, 2021
@luu-alex luu-alex mentioned this pull request Jun 18, 2021
@luu-alex luu-alex mentioned this pull request Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants