Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: ignore docs & .md #4077

Merged
merged 1 commit into from
May 21, 2021
Merged

CI: ignore docs & .md #4077

merged 1 commit into from
May 21, 2021

Conversation

GregTheGreek
Copy link
Contributor

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@render
Copy link

render bot commented May 20, 2021

Your Render PR Server URL is https://web3-js-pr-4077.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c2jbf4k64ckns9k7l8vg.

@coveralls
Copy link

coveralls commented May 20, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 861562212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.245%
Totals Coverage Status
Change from base Build 849889899: 0.0%
Covered Lines: 3157
Relevant Lines: 3928
💛 - Coveralls

spacesailor24
spacesailor24 approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No CHANGELOG update, but this doesn't affect the code for the user

@GregTheGreek GregTheGreek merged commit 1ed3c68 into 1.x May 21, 2021
@GregTheGreek GregTheGreek deleted the ci/ignore-files branch May 21, 2021 14:40
@GregTheGreek GregTheGreek mentioned this pull request May 26, 2021
Merged
14 tasks
spacesailor24 added a commit that referenced this pull request Jul 2, 2021
@spacesailor24 @GregTheGreek
Update 3.0.0 with 1.4.0 changes (#4164)
766157c 
* Release/1.3.5 (#3974)

* Update changelog

* Built dist

* Update version numbers

* v1.3.5

Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal>

* Bump underscore (#4051)

* bump underscore

* update package-locks

* bump lcoks again

* Release 1.3.6 (#4053)

* Update CHANGELOG and ran npm i

* Built lib for 1.3.6-rc.0

* v1.3.6-rc.0

* npm i

* Built lib for 1.3.6-rc.1

* v1.3.6-rc.1

* 1.3.6-rc.2 (#4059)

* npm i && npm audit fix

* Manually bump version to 1.3.6-rc.2

* Built lib for 1.3.6-rc.2

* v1.3.6-rc.2

* 1.3.6-rc.2 fixes (#4062)

* Manually update dependency versions to 1.3.6-rc.2

* Accidental commit

* npm i

* Manually update web3 dependency version to 1.3.6-rc.2

* npm i

* Built manually for 1.3.6-rc.2

* Update CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Add web3-core-helpers as dev dependency

* Add web3-core-helpers as dev dependency

* Fixing 1.3.6-rc.2 related issues (#4063)

* Remove web3-eth-ens as dependency

* Regen package-locks and build lib

* Remove dtslint from ci scripts (#4064)

* Remove web3-eth-ens as dependency

* Regen package-locks and build lib

* Remove npm run dtslint from build and lint

* 1.3.6-rc.2 Fixes (#4065)

* Remove web3-eth-ens as dependency

* Regen package-locks and build lib

* Remove npm run dtslint from build and lint

* Add back removed package: web3-eth-ens

* npm i

* Build lib

* Add back npm run dtslint

* Update geth-dev-assistant

* v1.3.6

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Add unsubscribeByID (#4061)

* adding function unsubscribe by id

* adding an unsubscribe testcase

* adding testcase

* seperated unsubscribebyid to its own method

* adding testcases

* adding await

* fixing testcases

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <alex@chainsafe.io>

* ignore .md and docs (#4077)

* adding berlin tx support (#4109)

* add berlin tx support

* update install locations

* update package name in comment

* fix existing tests to support new tx sigining format

* remove build

* remove old test case

* use latest ethereumjs/tx

* bump deps and fix test

* update hashes

* fix messageHash, decoding bug

* fix tests

* add hack

* adding eip2930 and common object

* fix lint updating package-lock

* fix berlin tx signing and recovery

* updating ethereumjs/tx package

* updating checksum

* removing helper.js

* updating changelog and docs

* fixing typo

Co-authored-by: Gregory Markou <gregorymarkou@gmail.com>

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth (#4154)

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Update scripts/e2e.geth.instamine.sh to use v1.10.3 of Geth

* Fix typo

* Release v1.4.0 (#4118)

* npm run build for 1.4.0-rc.0

* v1.4.0-rc.0

* 1.4.0 Geth version downgrade (#4149)

* Update pull Geth docker version from stable to pre-london (1.10.3)

* Update CHANGELOG

* v1.4.0

Co-authored-by: Ubuntu <ubuntu@ip-172-31-69-58.ec2.internal>
Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <alex@chainsafe.io>
Co-authored-by: Gregory Markou <gregorymarkou@gmail.com>
spacesailor24 pushed a commit that referenced this pull request Aug 26, 2021
@GregTheGreek @spacesailor24
ignore .md and docs (#4077)
bb06bb2
spacesailor24 added a commit that referenced this pull request Aug 26, 2021
@spacesailor24 @GregTheGreek
@exx8 @starwalker00 @mongolsteppe @blackblather @fulldecent @evertonfraga @jual3 @jdevcs
Update 3.x with latest 1.x (#4275)
b82880a 
* Merge conflitcs

* Add unsubscribeByID (#4061)

* adding function unsubscribe by id

* adding an unsubscribe testcase

* adding testcase

* seperated unsubscribebyid to its own method

* adding testcases

* adding await

* fixing testcases

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <alex@chainsafe.io>

* ignore .md and docs (#4077)

* Merge conflicts

* Merge conflicts

* Release v1.4.0 (#4118)

* npm run build for 1.4.0-rc.0

* v1.4.0-rc.0

* 1.4.0 Geth version downgrade (#4149)

* Update pull Geth docker version from stable to pre-london (1.10.3)

* Update CHANGELOG

* v1.4.0

* remove underscore (#4069)

* removed some of the underscore methods in web3-core-method

* removed underscore from bzz

* adding subscriptions

* fixing up test cases

* changing variable names

* removed underscore from formatters.js

* removed underscore from request manager and abi

* removing underscore in the rest of the web3 packages

* fixing exports

* fixing failing testcases

* removing underscore from tests

* addressing feedback

* removing unwanted code from transaction

* removing underscore from remaining packages

* updating change log

* addressing feedback

* adding strict equality

* efficient short circuiting

* fixing test case

* Merge conflicts

* Update docs 2 (#4188)

* add nonce to send options.

* add nonce to send options.

* Update CHANGELOG.md

* linting

* updating docs

* update web3-shh.rst : whisper-overview broken link (#4170)

whisper overview has been moved from https://github.com/ethereum/go-ethereum/wiki/Whisper to https://eth.wiki/concepts/whisper/whisper-overview

* [Docs] Fixed a broken link (#4151)

Original link gives out a 404, replaced by the closest thing I could find.

* Possible typo in docs (#4088)

I think the author missed a "this" in the phrase

* Typically you will have only one Web3 connection, use const (#3967)

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>

* Removing deprecation notice for HttpProvider (#4008)

* Removing deprecation notice for HttpProvider

From my view, it is just a provider with less capabilities than websockets, but still widely useful — and widely used as well.

@frozeman @nivida @GregTheGreek any thoughts?

* Update include_package-core.rst

* Update CHANGELOG.md

Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: Alex <alex.luu@mail.utoronto.ca>

* [Docs] Updated solidity example to modern syntax (#4147)

* [Docs] Updated solidity example to modern syntax

Replaced the old constructor function syntax with the modern one, added 'emit' to event calls, added pragma, added a valid bytes32 value and updated the JSON ABI.

* [Docs] Fixed a broken link (#1)

Original link gives out a 404, replaced by the proper guide.

Co-authored-by: Juan Alonso <Juan.Alonso@trimble.com>

* Revert "[Docs] Fixed a broken link (#1)"

This reverts commit 0de1272.

Co-authored-by: Juan Alonso <Juan.Alonso@trimble.com>

* added EIP-2718 and EIP-1559 documentation

* fixing typo

* addressing feedback

* changing possible types for maxPriorityFeePerGas

* updating maxFeePerGas type

* update changelog

Co-authored-by: exx8 <exx8eran@gmail.com>
Co-authored-by: starwalker00 <68958932+starwalker00@users.noreply.github.com>
Co-authored-by: mongolsteppe <75075420+mongolsteppe@users.noreply.github.com>
Co-authored-by: João Monteiro <joao.monteiro95@hotmail.com>
Co-authored-by: William Entriken <github.com@phor.net>
Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: Ev <evertonfrag@gmail.com>
Co-authored-by: Juan Alonso <Juan.Alonso@trimble.com>

* eth_feeHistory (EIP 1559) (#4191)

* WIP

* Add missing fields for test runner

* Correct function arguments for getFeeHistory

* getFeeHistory tests with correct arguments

* Init utils.toNumber function

* Rename toNumber test to hexToNumber

* Add inputFormatters to getFeeHistory

* Rename newestBlock to lastBlock. Update types for blockCount and lastBlock

* Add additional tests with different input types

* Add missing function export

* eth-feehistory docs (#4190)

* updating docs

* updating example

* updating types and adding example of list

* Update docs/web3-eth.rst

* Update docs/web3-eth.rst

* Update docs/web3-eth.rst

Co-authored-by: alex <luu.alex@outlook.com>
Co-authored-by: Wyatt Barnes <wyatt@writerof.software>

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: alex <luu.alex@outlook.com>

* Update CHANGELOG (#4193)

Test don't run when only changes to `CHANGELOG.md` have been made

* Merge conflicts

* Merge conflicts

* Merge conflicts

* Merge conflicts

* Merge conflicts

* Merge conflicts

* Merge conflicts

* Merge conflicts

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Alex <alex@chainsafe.io>
Co-authored-by: Gregory Markou <16929357+GregTheGreek@users.noreply.github.com>
Co-authored-by: exx8 <exx8eran@gmail.com>
Co-authored-by: starwalker00 <68958932+starwalker00@users.noreply.github.com>
Co-authored-by: mongolsteppe <75075420+mongolsteppe@users.noreply.github.com>
Co-authored-by: João Monteiro <joao.monteiro95@hotmail.com>
Co-authored-by: William Entriken <github.com@phor.net>
Co-authored-by: Ev <evertonfrag@gmail.com>
Co-authored-by: Juan Alonso <Juan.Alonso@trimble.com>
Co-authored-by: alex <luu.alex@outlook.com>
Co-authored-by: jdevcs <86780488+jdevcs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacesailor24 spacesailor24 spacesailor24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregTheGreek @coveralls @spacesailor24