Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ganache-core E2E test #3304

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Add ganache-core E2E test #3304

merged 2 commits into from
Jan 14, 2020

Conversation

cgewecke
Copy link
Collaborator

Description

Adds ganache-core as an E2E published target. Their unit tests (~500) use a range of Web3's modules, esp. different provider packages. This might be a useful check to run against #3190 since there are many changes to the WS provider there. Ganache has uncovered provider bugs here in the past.

Temporarily removes the Truffle E2E tests from the Travis run because they are on 1.2.1 and unclear when they will upgrade. tsc errors prevent Truffle from installing newer Web3 (they had to rework their types a bit when they ran 1.2.2). #3274 added a large Buidler project test suite as a Truffle substitute as well.

Commit fa8eedf contains a proof that the published branch is being used to run the tests.

Type of change

  • E2E test

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.922% when pulling ec86978 on test/e2e-ganache-core into 9b4b68a on 1.x.

@cgewecke cgewecke added 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Jan 11, 2020
Copy link
Contributor

@nivida nivida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you create an issue to re-add the truffle tests later when they have updated truffle to the latest version? (just to be sure we do not forget about it)

@cgewecke
Copy link
Collaborator Author

@nivida - Issue added in #3308

@nivida nivida added CI and removed Review Needed Maintainer(s) need to review labels Jan 14, 2020
@nivida nivida merged commit 3f839c9 into 1.x Jan 14, 2020
@nivida nivida deleted the test/e2e-ganache-core branch January 16, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants