Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ganache-core as an E2E published target. Their unit tests (~500) use a range of Web3's modules, esp. different provider packages. This might be a useful check to run against #3190 since there are many changes to the WS provider there. Ganache has uncovered provider bugs here in the past.
Temporarily removes the Truffle E2E tests from the Travis run because they are on 1.2.1 and unclear when they will upgrade.
tsc
errors prevent Truffle from installing newer Web3 (they had to rework their types a bit when they ran 1.2.2). #3274 added a large Buidler project test suite as a Truffle substitute as well.Commit fa8eedf contains a proof that the published branch is being used to run the tests.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success and extended the tests if necessary.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.