Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Truffle E2E test #3308

Closed
cgewecke opened this issue Jan 13, 2020 · 1 comment
Closed

Re-enable Truffle E2E test #3308

cgewecke opened this issue Jan 13, 2020 · 1 comment
Assignees
Labels
1.x 1.0 related issues

Comments

@cgewecke
Copy link
Collaborator

This is a tracking issue to make sure we don't forget to begin running the E2E test which was built to validate each pull request against Truffle tsc builds and contract tests.

As noted in #3304, Truffle has reverted to 1.2.1 because truffle-contract needs changes to its emitter wrapping to correctly handle the confirmations logic fixed in 1.2.2. (See truffle 2688)

We cannot inject 1.2.2 and above into their test suite because the 1.2.1 and 1.2.2 types are managed differently there and tsc fails on install.

@cgewecke cgewecke mentioned this issue Jan 13, 2020
12 tasks
@cgewecke cgewecke added 1.x 1.0 related issues CI labels Jan 13, 2020
@cgewecke cgewecke self-assigned this Jan 13, 2020
@cgewecke
Copy link
Collaborator Author

cgewecke commented Jun 9, 2020

Closing, we've added two additional E2E targets which cover +/- the same ground.

  • gnosis/dex-react (TS compilation)
  • mosaic (@truffle/contract unit tests)

Truffle is locked on 1.2.1 and there's no movement over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

No branches or pull requests

1 participant