Add E2E Mosaic test #3274
Merged
Add E2E Mosaic test #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivida
reviewed
Dec 16, 2019
| @@ -0,0 +1,56 @@ | |||
| # ------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Oh! Well documented here! Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #3266, larger Solidity contract unit test suites that use Web3 are seeing random crashes and poor performance using Web3 >= 1.2.2. Believe this bug is at Truffle ... (see truffle 2688)
PR models that use-case by virtually publishing Web3 and running the unit tests of a fork of mosaicdao/mosaic-1. The project was selected because it reported the same bug and it's relatively small (~300 unit tests).
The fork is adapted to use the Buidler test runner instead of Truffle. The change-set for those modifications can be seen here.
Truffle is quite complex and ships as a web-packed bundle. It's also downgraded Web3 to 1.2.1 and the latest state of Web3 does not install there because recent TS fixes at Truffle were reverted.
Buidler is simpler / more modular and allows us to use yarn resolutions to coerce all nested web3 packages in the target project to the one we want.
This is a useful replacement for the (now) broken Truffle E2E test as well.
Proofs that the test correctly uses virtually published Web3
Fixes #3266
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success and extended the tests if necessary.npm run build-alland tested the resulting file/'s fromdistfolder in a browser.CHANGELOG.mdfile in the root folder.