Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for new lint check: missing META.yml for new top-level directory #10552

Open
zcorpan opened this issue Apr 20, 2018 · 7 comments
Open

Idea for new lint check: missing META.yml for new top-level directory #10552

zcorpan opened this issue Apr 20, 2018 · 7 comments

Comments

@zcorpan
Copy link
Member

zcorpan commented Apr 20, 2018

Related to #5915

It'd be nice if new top-level directories have OWNERS files from the start when they are created (or subdirectory of css/).

cc @gsnedders

@zcorpan
Copy link
Member Author

zcorpan commented May 17, 2018

@gsnedders says

it'd have to be a lint_all_files check

@gsnedders
Copy link
Member

@foolip @Hexcles this seems like it would be awkward for people introducing new directories through the Blink sync, as OWNERS files aren't sync'd (given normal Chromium OWNERS files are present in the Chromium tree)

@Hexcles
Copy link
Member

Hexcles commented May 21, 2018

You are right. We don't sync OWNERS files.

If we want to add a wpt lint for this, we may need a command-line flag to turn it off, which should be useful to us and perhaps others as well.

@zcorpan
Copy link
Member Author

zcorpan commented May 21, 2018

That may solve itself when we rename OWNERS to NOTIFY.

zcorpan added a commit that referenced this issue Jun 20, 2018
gsnedders pushed a commit that referenced this issue Jun 28, 2018
gsnedders pushed a commit that referenced this issue Jun 28, 2018
gsnedders pushed a commit that referenced this issue Jun 28, 2018
@gsnedders gsnedders reopened this Jun 28, 2018
gsnedders pushed a commit that referenced this issue Jun 29, 2018
@foolip foolip changed the title Idea for new lint check: missing OWNERS for new top-level directory Idea for new lint check: missing META.yml for new top-level directory Jul 11, 2018
@foolip
Copy link
Member

foolip commented Jul 11, 2018

OWNERS have been renamed to META.yml and those are imported into Blink, so the lint problem is gone.

@foolip
Copy link
Member

foolip commented Nov 6, 2019

@zcorpan is this something you're planning to tackle? It looks like I end up adding them more often that I'd like:

@zcorpan
Copy link
Member Author

zcorpan commented Nov 6, 2019

I can try to fit this in as part of the review velocity work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants