Lint that META.yml files exist #11734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
reviewed
Jun 29, 2018
| @@ -264,6 +264,8 @@ def name_is_non_test(self): | |||
| self.name_prefix("MANIFEST") or | |||
| self.filename == "META.yml" or | |||
| self.filename.startswith(".") or | |||
| self.filename == "OWNERS" or | |||
There was a problem hiding this comment.
When is this value necessary?
jugglinmike
reviewed
Jun 29, 2018
| @@ -264,6 +264,8 @@ def name_is_non_test(self): | |||
| self.name_prefix("MANIFEST") or | |||
| self.filename == "META.yml" or | |||
| self.filename.startswith(".") or | |||
| self.filename == "OWNERS" or | |||
| self.filename == "META.yml" or | |||
There was a problem hiding this comment.
This value is already included in the expression
There was a problem hiding this comment.
Hah, I never noticed that when I reviewed this before. I suck.
jgraham
requested changes
Jul 31, 2018
| meta_yml_extensions_pattern = re.compile(b"^[a-zA-z0-9_]+:$") | ||
| meta_yml_item_pattern = re.compile(b"^ - [a-zA-Z0-9-]+$") | ||
|
|
||
| def check_meta_yml_contents(repo_root, path, contents): |
There was a problem hiding this comment.
I don't like this part much. I think we should use an actual yml parser to parse the files, and shouldn't require that all directories have suggested reviewers.
| # dirs represents whether there's a META.yml file, value is a boolean. | ||
| dirs = {} | ||
| errors = [] | ||
| reviewer_in_subdirs = [ |
There was a problem hiding this comment.
So I don't think this should mention reviewers but the concept of requiring at least one META.yml per independent part of spec seems sound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10552. Previously landed in #11092, reverted due to #11722.
TODO: The failure that caused #11722 is the same underlying issue as #9171: as an optimisation, we only pass changed files to lint, which doesn't suffice for the things that need to consider more than one file.