Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signed-exchange/META.yml (suggested reviewers) #13791

Merged
merged 3 commits into from
Nov 2, 2018
Merged

Add signed-exchange/META.yml (suggested reviewers) #13791

merged 3 commits into from
Nov 2, 2018

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 30, 2018

No description provided.

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@foolip
Copy link
Member Author

foolip commented Oct 30, 2018

@irori @jyasskin can you confirm you're OK with this? @irori, I've sent an invite to the reviewers team that you'll need to accept in order to be able to be added as a reviewer automatically, and to merge PRs.

irori
irori approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@irori irori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jyasskin
jyasskin approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyaxt, are you also a good person to list here?

@nyaxt
Copy link
Member

nyaxt commented Nov 2, 2018

Yes. Feel free to add me too.

@foolip foolip merged commit 5d1aee1 into master Nov 2, 2018
@foolip foolip deleted the foolip/signed-exchange-META branch November 2, 2018 14:18
@foolip foolip mentioned this pull request Nov 6, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyaxt nyaxt nyaxt approved these changes

@irori irori irori approved these changes

@jyasskin jyasskin jyasskin approved these changes

Assignees
No one assigned
Labels
signed-exchange status:needs-reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foolip @wpt-pr-bot @nyaxt @irori @jyasskin