-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monitoring to objects cleaner #3608
Conversation
d1754b9
to
64a1aa5
Compare
64a1aa5
to
600218a
Compare
f92e3bd
to
d36e578
Compare
324c0f5
to
f8361fc
Compare
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
f8361fc
to
dabf1f2
Compare
@enekofb @jpellizzari please do not merge this PR until two other PRs for this issue are merged (in quickstart and OSS). |
As discussed, only added metrics for calling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
8e69f61
to
c0a5c57
Compare
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
c0a5c57
to
758431a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work on cleaning up the enabled/disabled
discrepancy
That's @enekofb 's doing. Yeah, enabled/disabled was somewhat confusing. |
The original intent was to have people opt out of the cleaner by exception. I kinda messed up the naming, so glad that is cleaned up. |
Yes, if I did it myself, I would have renamed it to |
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
758431a
to
8e1331c
Compare
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency. Remove unneeded comment.
8e1331c
to
5f9bf4b
Compare
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency. Remove unneeded comment.
5f9bf4b
to
6ad9524
Compare
Closes #3043 |
Closes #3043
What changed?
To enhance the troubleshooting experience of the Explorer's management path for users, we have added RED metrics to the objects cleaner component of Explorer:
Added recording of objects cleaner status and object removal operations as metrics.
Introduced Grafana dashboard panels: "Objects Cleaner Request Rate" and "Objects Cleaner Requests Duration" for the objects cleaner.
Updated Explorer's monitoring documentation to include the new metrics.
Release Notes
(Include in the next release notes under the Highlights section)
Highlights
RED metrics and corresponding Grafana dashboard panels have been added to the objects cleaner component of Explorer, enhancing the troubleshooting capabilities in Explorer's management path.