Add monitoring to objects cleaner #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
14 times, most recently
from
d1754b9
to
64a1aa5
Compare
enekofb
reviewed
Nov 14, 2023
enekofb
reviewed
Nov 14, 2023
enekofb
reviewed
Nov 14, 2023
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
from
64a1aa5
to
600218a
Compare
enekofb
reviewed
Nov 14, 2023
enekofb
reviewed
Nov 14, 2023
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
8 times, most recently
from
f92e3bd
to
d36e578
Compare
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
3 times, most recently
from
324c0f5
to
f8361fc
Compare
opudrovs
added a commit
that referenced
this pull request
Nov 17, 2023
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
from
f8361fc
to
dabf1f2
Compare
|
@enekofb @jpellizzari please do not merge this PR until two other PRs for this issue are merged (in quickstart and OSS). |
|
As discussed, only added metrics for calling |
enekofb
approved these changes
Nov 17, 2023
opudrovs
added a commit
that referenced
this pull request
Nov 17, 2023
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
from
8e69f61
to
c0a5c57
Compare
opudrovs
added a commit
that referenced
this pull request
Nov 17, 2023
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
from
c0a5c57
to
758431a
Compare
jpellizzari
approved these changes
Nov 17, 2023
That's @enekofb 's doing. Yeah, enabled/disabled was somewhat confusing. |
The original intent was to have people opt out of the cleaner by exception. I kinda messed up the naming, so glad that is cleaned up. |
|
Yes, if I did it myself, I would have renamed it to |
opudrovs
added a commit
that referenced
this pull request
Nov 17, 2023
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
from
758431a
to
8e1331c
Compare
opudrovs
added a commit
that referenced
this pull request
Nov 17, 2023
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency. Remove unneeded comment.
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
from
8e1331c
to
5f9bf4b
Compare
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency. Remove unneeded comment.
opudrovs
force-pushed
the
3043-add-monitoring-to-object-cleaner
branch
from
5f9bf4b
to
6ad9524
Compare
|
Closes #3043 |
opudrovs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3043
What changed?
To enhance the troubleshooting experience of the Explorer's management path for users, we have added RED metrics to the objects cleaner component of Explorer:
Added recording of objects cleaner status and object removal operations as metrics.
Introduced Grafana dashboard panels: "Objects Cleaner Request Rate" and "Objects Cleaner Requests Duration" for the objects cleaner.
Updated Explorer's monitoring documentation to include the new metrics.
Release Notes
(Include in the next release notes under the Highlights section)
Highlights
RED metrics and corresponding Grafana dashboard panels have been added to the objects cleaner component of Explorer, enhancing the troubleshooting capabilities in Explorer's management path.