-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add monitoring to object cleaner (#3608)
Add setting objects cleaner status and recording it as a metric. Add cleaner metrics for removing old objects and corresponding test. Fix object cleaner not starting. Rename `reterr` to `retErr` for consistency.
- Loading branch information
Showing
8 changed files
with
202 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
package metrics | ||
|
||
import ( | ||
"time" | ||
|
||
"github.com/prometheus/client_golang/prometheus" | ||
) | ||
|
||
const ( | ||
cleanerSubsystem = "objects_cleaner" | ||
|
||
// cleaner actions | ||
removeObjectsAction = "RemoveObjects" | ||
|
||
FailedLabel = "error" | ||
SuccessLabel = "success" | ||
) | ||
|
||
var cleanerWatcher = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | ||
Subsystem: cleanerSubsystem, | ||
Name: "status", | ||
Help: "cleaner status", | ||
}, []string{"status"}) | ||
|
||
var CleanerLatencyHistogram = prometheus.NewHistogramVec(prometheus.HistogramOpts{ | ||
Subsystem: cleanerSubsystem, | ||
Name: "latency_seconds", | ||
Help: "cleaner latency", | ||
Buckets: prometheus.LinearBuckets(0.01, 0.01, 10), | ||
}, []string{"action", "status"}) | ||
|
||
var CleanerInflightRequests = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | ||
Subsystem: cleanerSubsystem, | ||
Name: "inflight_requests", | ||
Help: "number of cleaner in-flight requests.", | ||
}, []string{"action"}) | ||
|
||
func init() { | ||
prometheus.MustRegister(cleanerWatcher) | ||
prometheus.MustRegister(CleanerLatencyHistogram) | ||
prometheus.MustRegister(CleanerInflightRequests) | ||
} | ||
|
||
// CleanerWatcherDecrease decreases cleaner_watcher metric for status | ||
func CleanerWatcherDecrease(status string) { | ||
cleanerWatcher.WithLabelValues(status).Dec() | ||
} | ||
|
||
// CleanerWatcherIncrease increases cleaner_watcher metric for status | ||
func CleanerWatcherIncrease(status string) { | ||
cleanerWatcher.WithLabelValues(status).Inc() | ||
} | ||
|
||
func CleanerSetLatency(status string, duration time.Duration) { | ||
CleanerLatencyHistogram.WithLabelValues(removeObjectsAction, status).Observe(duration.Seconds()) | ||
} | ||
|
||
func CleanerAddInflightRequests(number float64) { | ||
CleanerInflightRequests.WithLabelValues(removeObjectsAction).Add(number) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters