Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring to object cleaner #9

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add monitoring to object cleaner #9

merged 1 commit into from
Nov 17, 2023

Conversation

opudrovs
Copy link
Contributor

@opudrovs opudrovs commented Nov 15, 2023 •
edited
Loading

Part of weaveworks/weave-gitops-enterprise#3043

  • Added Grafana dashboard panels ("Objects Cleaner Request Rate" and "Objects Cleaner Requests Duration") for the object cleaner component of Explorer, similar to Indexer Writes panels.

Testing:
To test this PR, please check out the following enterprise PR:
weaveworks/weave-gitops-enterprise#3608
and update the main branch in tools/dev-resources/monitoring/wge-monitoring.yaml
https://github.com/weaveworks/weave-gitops-enterprise/blob/2fb73de213943d3fc0763b42435a88bc3a531114/tools/dev-resources/monitoring/wge-monitoring.yaml#L9
to the current branch:

branch: WGE3043-add-monitoring-to-object-cleaner

@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch 3 times, most recently from e682c75 to 37428cc Compare November 17, 2023 00:14
@opudrovs opudrovs marked this pull request as ready for review November 17, 2023 10:10
enekofb
enekofb approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested that works in a previous pr

asked questions about the background on fixing the action.

monitoring/weave-gitops/dashboards/explorer.json Outdated Show resolved Hide resolved
monitoring/weave-gitops/dashboards/explorer.json Outdated Show resolved Hide resolved
@opudrovs opudrovs force-pushed the WGE3043-add-monitoring-to-object-cleaner branch from fa42edc to 9859b81 Compare November 17, 2023 19:10
@opudrovs opudrovs merged commit 1ff313a into main Nov 17, 2023
@opudrovs opudrovs deleted the WGE3043-add-monitoring-to-object-cleaner branch November 17, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enekofb enekofb enekofb approved these changes

@jpellizzari jpellizzari Awaiting requested review from jpellizzari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opudrovs @enekofb