-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate WavefrontProxyClient [WIP] #50
Conversation
@laullon At a high level, here's what we need to do:
Since both the proxy and direct ingestion will be over HTTP going forward, the configuration for both is similar barring the URL endpoint (batchsize, queuesize, flushinterval etc apply to both). And it will be backed by a singular WavefrontClient |
* master: Add content on custom tracing port (#56) Update the README.MD file (#54) speed up histo tests (#53) clarify 64-bit misalignment Align LineHandler struct fields to allow atomic access (#52) tweak source formatting Enhance the wavefront-sdk-go to support Kubernetes environments (#47) # Conflicts: # application/application.go # internal/formatter.go
A lot of the changes break backwards compatibility. It'd be nice to retain backwards compatibility as much as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
How can I use the new Sender that only takes a URL? Looks like
currently doesn't work, as NewSender is undefined. |
This is not yet released, if you want to test it make sure you point your dependencies to master branch. |
@laullon is there a timeline to release this? |
Addresses Issue #46