Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate WavefrontProxyClient [WIP] #50

Merged
merged 13 commits into from
Jul 26, 2020
Merged

Conversation

laullon
Copy link
Contributor

@laullon laullon commented May 26, 2020

Addresses Issue #46

@laullon laullon requested a review from vikramraman May 26, 2020 09:03
@vikramraman
Copy link
Contributor

@laullon At a high level, here's what we need to do:

  • Add a construct similar to WavefrontClientFactory
  • Add a WavefrontMultiClient
  • Latest versions of the proxy support receiving all atoms (metrics, histograms, spans etc) using a single port over HTTP. So we will deprecate the existing Proxy and Direct senders in favor of the new WavefrontClientFactory.

Since both the proxy and direct ingestion will be over HTTP going forward, the configuration for both is similar barring the URL endpoint (batchsize, queuesize, flushinterval etc apply to both). And it will be backed by a singular WavefrontClient

* master:
  Add content on custom tracing port (#56)
  Update the README.MD file (#54)
  speed up histo tests (#53)
  clarify 64-bit misalignment
  Align LineHandler struct fields to allow atomic access (#52)
  tweak source formatting
  Enhance the wavefront-sdk-go to support Kubernetes environments (#47)

# Conflicts:
#	application/application.go
#	internal/formatter.go
@vikramraman
Copy link
Contributor

vikramraman commented Jul 8, 2020

A lot of the changes break backwards compatibility. It'd be nice to retain backwards compatibility as much as possible.

internal/formatter.go Outdated Show resolved Hide resolved
wavefront/client.go Outdated Show resolved Hide resolved
internal/formatter.go Outdated Show resolved Hide resolved
wavefront/client.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vikramraman vikramraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more comments.

senders/proxy.go Outdated Show resolved Hide resolved
senders/types.go Outdated Show resolved Hide resolved
senders/proxy.go Outdated Show resolved Hide resolved
senders/direct.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
internal/reporter.go Outdated Show resolved Hide resolved
senders/client_multi.go Outdated Show resolved Hide resolved
senders/client_multi.go Outdated Show resolved Hide resolved
senders/client_multi.go Outdated Show resolved Hide resolved
senders/client_factory.go Show resolved Hide resolved
Copy link
Contributor

@vikramraman vikramraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vikramraman vikramraman merged commit b5d9878 into master Jul 26, 2020
@randallt
Copy link

How can I use the new Sender that only takes a URL? Looks like

import (
	wfsender "github.com/wavefronthq/wavefront-sdk-go/senders"
)

func InitTracing(serviceName string, applicationName string) wfsender.Sender {
	sender, err := wfsender.NewSender("http://wfproxy.wavefront:2878")
	if err != nil {
		panic(err)
	}
	return sender
}

currently doesn't work, as NewSender is undefined.

@laullon
Copy link
Contributor Author

laullon commented Sep 22, 2020

This is not yet released, if you want to test it make sure you point your dependencies to master branch.

@randallt
Copy link

@laullon is there a timeline to release this?

@LukeWinikates LukeWinikates deleted the laullon/MONIT-19475 branch August 18, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants