Enhance the wavefront-sdk-go to support Kubernetes environments #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikramraman
reviewed
May 21, 2020
vikramraman
reviewed
May 21, 2020
application/application.go
Outdated
| func (app *Tags) AddCustomTagsFromEnv(regx string) { | ||
| r, err := regexp.Compile(regx) | ||
| if err != nil { | ||
| log.Printf("Error creating custom tags: %v\n", err) |
There was a problem hiding this comment.
Return an error here rather than just log it?
vikramraman
reviewed
May 21, 2020
|
|
||
| // AddCustomTagFromEnv Set a custom tag from the given environment variable. | ||
| func (app *Tags) AddCustomTagFromEnv(varName, tag string) { | ||
| v := os.Getenv(varName) |
There was a problem hiding this comment.
Maybe return an error if the env var doesn't exist?
vikramraman
approved these changes
May 26, 2020
laullon
added a commit
that referenced
this pull request
Jun 30, 2020
* master: Add content on custom tracing port (#56) Update the README.MD file (#54) speed up histo tests (#53) clarify 64-bit misalignment Align LineHandler struct fields to allow atomic access (#52) tweak source formatting Enhance the wavefront-sdk-go to support Kubernetes environments (#47) # Conflicts: # application/application.go # internal/formatter.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.