-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content on custom tracing port #56
Conversation
CC @srujann The doc link is broken for now until the changes get pushed to mater. |
README.md
Outdated
Depending on the data you wish to send to Wavefront (metrics, distributions (histograms) and/or spans), enable the relevant ports on the proxy and initialize the proxy sender as follows: | ||
Depending on the data you wish to send to Wavefront (metrics, distributions (histograms) and/or spans), enable the relevant ports on the proxy and initialize the proxy sender. | ||
|
||
When you use a Sender SDK, you won’t see span-level RED metrics by default unless you use the Wavefront proxy and define a custom tracing port (`tracingPort`). See [Instrument Your Application with Wavefront Sender SDKs](https://www.wavefront.com/tracing_instrumenting_frameworks.html/#instrument-your-application-with-wavefront-sender-sdks) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a subsection title that this is related to sending spans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! There was a tracing span subsection. I moved it there.
README.md
Outdated
@@ -266,6 +265,8 @@ sender.SendDistribution("request.latency", centroids, hgs, 0, "appServer1", map[ | |||
|
|||
#### Tracing Spans | |||
|
|||
When you use a Sender SDK, you won’t see span-level RED metrics by default unless you use the Wavefront proxy and define a custom tracing port (`TracingPort`). See [Instrument Your Application with Wavefront Sender SDKs](https://www.wavefront.com/tracing_instrumenting_frameworks.html/#instrument-your-application-with-wavefront-sender-sdks) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the given link doesn't work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Fixed. :)
* master: Add content on custom tracing port (#56) Update the README.MD file (#54) speed up histo tests (#53) clarify 64-bit misalignment Align LineHandler struct fields to allow atomic access (#52) tweak source formatting Enhance the wavefront-sdk-go to support Kubernetes environments (#47) # Conflicts: # application/application.go # internal/formatter.go
Add content on custom tracing port.