Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.1.2] Combobox placeholder remains displayed when values selected #16493

Closed
marcpaskell opened this issue Jan 22, 2023 · 0 comments · Fixed by #16565 or #17122
Closed

[Bug Report][3.1.2] Combobox placeholder remains displayed when values selected #16493

marcpaskell opened this issue Jan 22, 2023 · 0 comments · Fixed by #16565 or #17122
Assignees
@johnleider
Labels
C: VCombobox VCombobox T: bug Functionality that does not work as intended/expected
Milestone
v3.1.x

Comments

@marcpaskell
Copy link

Environment

Vuetify Version: 3.1.2
Vue Version: 3.2.45
Browsers: Chrome 109.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

Just add a placeholder attr to a combobox and then select a value

Expected Behavior

no placeholder displayed

Actual Behavior

placeholder displayed

Reproduction Link

https://codepen.io/pasco82/pen/qByxZov
gitemad added a commit to gitemad/vuetify that referenced this issue Feb 1, 2023
@gitemad
fix(VTextField): remain placeholder after values selected
52fe03d 
fixes vuetifyjs#16519
fixes vuetifyjs#16493
Fix placeholder remains displayed when selecting items in components like VCombobox and VAutoComplete
@gitemad gitemad mentioned this issue Feb 1, 2023
Merged
gitemad added a commit to gitemad/vuetify that referenced this issue Feb 9, 2023
@gitemad
fix(VTextField): remain placeholder after values selected
b90c5d4 
fixes vuetifyjs#16519
fixes vuetifyjs#16493
Fix placeholder remains displayed when selecting items in components like VCombobox and VAutoComplete
johnleider added a commit that referenced this issue Mar 28, 2023
@gitemad @johnleider
fix(VTextField): remain placeholder after values selected (#16565)
33cc351 
fixes #16519
fixes #16493

Co-authored-by: John Leider <john@vuetifyjs.com>
KaelWD added a commit that referenced this issue Apr 4, 2023
@KaelWD
Revert "fix(VTextField): remain placeholder after values selected (#1…
5ac0fa9 
…6565)"

This reverts commit 33cc351.

fixes #17039
reopens #16493, #16519
@KaelWD KaelWD reopened this Apr 4, 2023
@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VCombobox VCombobox labels Apr 4, 2023
@KaelWD KaelWD added this to the v3.x.x milestone Apr 4, 2023
@github-actions github-actions bot removed the S: triage label Apr 4, 2023
@johnleider johnleider self-assigned this Apr 10, 2023
johnleider added a commit that referenced this issue Apr 10, 2023
@johnleider
fix(VTextField): placeholder show logic
aab0a31 
fixes #16519
fixes #16493
@johnleider johnleider mentioned this issue Apr 10, 2023
Merged
@KaelWD KaelWD modified the milestones: v3.x.x, v3.1.x Apr 12, 2023
KaelWD added a commit that referenced this issue Apr 12, 2023
@johnleider @KaelWD
fix(VCombobox): hide placeholder when dirty (#17122)
69ce260 
fixes #16519
fixes #16493

Co-authored-by: Kael <kaelwd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VCombobox VCombobox T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v3.1.x
3 participants
@marcpaskell @johnleider @KaelWD