-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VTextField): remain placeholder after values selected #16565
fix(VTextField): remain placeholder after values selected #16565
Conversation
fixes vuetifyjs#16519 fixes vuetifyjs#16493 Fix placeholder remains displayed when selecting items in components like VCombobox and VAutoComplete
3628849
to
b90c5d4
Compare
Can you also try to resolve the Select placeholder issue as part of this PR? <template>
<v-app>
<v-main>
<v-autocomplete
v-model="values"
:items="items"
label="Autocomplete"
placeholder="Select Item"
multiple
/>
<v-combobox
v-model="values"
:items="items"
label="Combobox"
multiple
placeholder="asdfasdfasdf"
/>
<v-select
v-model="values"
:items="items"
label="Select"
multiple
placeholder="asdfasdfasdf"
/>
</v-main>
</v-app>
</template>
<script>
export default {
data: () => ({
items: ['foo', 'bar', 'fizz', 'buzz'],
values: [],
}),
}
</script> |
…er-when-values-selected
Sure. I fixed it. |
fac4be4
to
57a81ed
Compare
persistent-placeholder is now broken: <template>
<v-app>
<v-main>
<v-autocomplete
v-model="values"
:items="items"
label="Autocomplete"
placeholder="Select Item"
:multiple="multiple"
persistent-placeholder
/>
<v-combobox
v-model="values"
:items="items"
label="Combobox"
:multiple="multiple"
placeholder="asdfasdfasdf"
persistent-placeholder
/>
<v-select
v-model="values"
:items="items"
label="Select"
:multiple="multiple"
placeholder="asdfasdfasdf"
persistent-placeholder
/>
</v-main>
</v-app>
</template>
<script>
export default {
data: () => ({
items: ['foo', 'bar', 'fizz', 'buzz'],
multiple: true,
values: [],
}),
}
</script> |
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good except the unrelated changes to the package.json files. Can you remove them please?
I fixed the conflicts. |
Description
Fix placeholder remains displayed when selecting items in components like VCombobox and VAutoComplete.
I solve this issue using isDirty value in VTextField component.
fixes #16519
fixes #16493
Markup:
VAutoComplete
VCombobox