fix(VTextField): placeholder show logic

fixes #16519 fixes #16493
vuetifyjs · Apr 10, 2023 · aab0a31 · aab0a31
1 parent 0709890
commit aab0a31
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/packages/vuetify/src/components/VFileInput/VFileInput.tsx b/packages/vuetify/src/components/VFileInput/VFileInput.tsx
@@ -53,7 +53,6 @@ export const VFileInput = genericComponent<VFileInputSlots>()({
     multiple: Boolean,
     hint: String,
     persistentHint: Boolean,
-    placeholder: String,
     showSize: {
       type: [Boolean, Number] as PropType<boolean | 1000 | 1024>,
       default: false,

diff --git a/packages/vuetify/src/components/VTextField/VTextField.tsx b/packages/vuetify/src/components/VTextField/VTextField.tsx
@@ -212,6 +212,16 @@ export const VTextField = genericComponent<Omit<VInputSlots & VFieldSlots, 'defa
                   default: ({
                     props: { class: fieldClass, ...slotProps },
                   }) => {
+                    const placeholder = computed(() => {
+                      if (isDirty.value || (
+                        !isFocused.value &&
+                        props.label &&
+                        !props.persistentPlaceholder
+                      )) return ''
+
+                      return props.placeholder
+                    })
+
                     const inputNode = (
                       <input
                         ref={ inputRef }
@@ -224,7 +234,7 @@ export const VTextField = genericComponent<Omit<VInputSlots & VFieldSlots, 'defa
                         readonly={ isReadonly.value }
                         disabled={ isDisabled.value }
                         name={ props.name }
-                        placeholder={ props.placeholder }
+                        placeholder={ placeholder.value }
                         size={ 1 }
                         type={ props.type }
                         onFocus={ onFocus }