BREAKING CHANGE: Remove deprecated folders #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 5a325f1 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/612e9ce750846b00073cf148 😎 Browse the preview: https://deploy-preview-927--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a325f1:
|
tlgimenes
changed the title
|
Won't this break all our stores? |
They won't be able to upgrade to the latest version anymore. That's ok for now I guess because it will allow us to develop our starters faster |
|
Should we create a deprecated branch to continue maintaining (bug fix) or just let it go? |
yes! we are creating a |
emersonlaurentino
approved these changes
Aug 31, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Sep 14, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Sep 15, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Sep 16, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Sep 17, 2021
* Spinner component for loading * Spinner exports * Fix data-testid Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> * remove explicit children prop Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> * BREAKING CHANGE: Remove deprecated folders (#927) * feat(store-ui): adding list atom (#918) Create List component as an Atom. * feat(store-ui): Add Skeleton Atom (#911) * Add skeleton atom * Move animation to theme * Import tailwind utilities * Update test * Use only 1 div * Update story * Extend HTMLDivElement * Spinner exports * lint * Fix Spinner test * removing duplicated line in package.json Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> Co-authored-by: Tiago Gimenes <tlgimenes@gmail.com> Co-authored-by: Bento Pereira <40964933+bentoper@users.noreply.github.com> Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Gmantiqueira
pushed a commit
that referenced
this pull request
Sep 17, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Sep 17, 2021
rrbambokian
pushed a commit
that referenced
this pull request
Sep 30, 2021
* Spinner component for loading * Spinner exports * Fix data-testid Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> * remove explicit children prop Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> * BREAKING CHANGE: Remove deprecated folders (#927) * feat(store-ui): adding list atom (#918) Create List component as an Atom. * feat(store-ui): Add Skeleton Atom (#911) * Add skeleton atom * Move animation to theme * Import tailwind utilities * Update test * Use only 1 div * Update story * Extend HTMLDivElement * Spinner exports * lint * Fix Spinner test * removing duplicated line in package.json Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> Co-authored-by: Tiago Gimenes <tlgimenes@gmail.com> Co-authored-by: Bento Pereira <40964933+bentoper@users.noreply.github.com> Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Gmantiqueira
pushed a commit
that referenced
this pull request
Oct 12, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Oct 14, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Oct 21, 2021
Gmantiqueira
pushed a commit
that referenced
this pull request
Oct 21, 2021
* BREAKING CHANGE: Remove deprecated folders (#927) * feat(store-ui): adding list atom (#918) Create List component as an Atom. * feat(store-ui): Add Skeleton Atom (#911) * Add skeleton atom * Move animation to theme * Import tailwind utilities * Update test * Use only 1 div * Update story * Extend HTMLDivElement * Spinner exports * lint * Loading Button molecule * removing duplicated line in package.json * Remove loading prop default value * Adds component inheritance inside docs * change spread props naming Co-authored-by: Tiago Gimenes <tlgimenes@gmail.com> Co-authored-by: Bento Pereira <40964933+bentoper@users.noreply.github.com> Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR removes deprecated folders as this issue requested
#920
How it works?
We are still in alpha. Let's use this time to remove all deprecated folders. From now on, the old state will be on the branch
legacy.Also, this PR shrinks the store-ui size to 10Kb max
How to test it?
I've upgraded our base.store to work with this
vtex-sites/base.store#20