Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated folders #920

Closed
tlgimenes opened this issue Aug 25, 2021 · 0 comments
Closed

Remove deprecated folders #920

tlgimenes opened this issue Aug 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@tlgimenes
Copy link
Contributor

tlgimenes commented Aug 25, 2021

Hi people!

We are currently developing new components to store-ui while still maintaining the old components inside a folder called "deprecated". Since we are using tsdx for bundling, we can't really create two entrypoints and the bundle analyser analyses all components, the new and the old ones.
Also, last time I tried creating a store using only the new components I had an issue where theme-ui was being included into my final bundle.
Another problem this migration causes is that we can't really advance really fast because we also need to maintain some old APIs and packages, like theme-store and plugin-theme-ui. For this and other problems, I propose:

  1. Create a branch called legacy with the current state of the master branch
  2. Remove the following packages:
    2.1. gatsby-plugin-theme-store
    2.2. gatsby-plugin-theme-ui
    2.3. gatsby-plugin-i18n
    2.4. gatsby-plugin-performance
    2.5. deprecated folder inside store-ui
    2.6. decrease max bundle size for store-ui to 15Kb

With this, I hope to develop the feature faster without having to backport everything everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant