feat(store-ui): Spinner atom #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: fa00fd2 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6144e328ac0ed900095fac2d 😎 Browse the preview: https://deploy-preview-961--storeui.netlify.app |
Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com>
Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fa00fd2:
|
Create List component as an Atom.
* Add skeleton atom * Move animation to theme * Import tailwind utilities * Update test * Use only 1 div * Update story * Extend HTMLDivElement
Gmantiqueira
force-pushed
the
feat/loading-spinner
branch
from
802c06e to
a4f2ba2
Compare
igorbrasileiro
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Remove duplicated entry on package.json, and it's ok for me. Great job, @Gmantiqueira.
packages/store-sdk/package.json
Outdated
| @@ -41,6 +41,7 @@ | |||
| "react": "^17.0.2" | |||
| }, | |||
| "devDependencies": { | |||
| "@testing-library/react-hooks": "^7.0.2", | |||
rrbambokian
pushed a commit
that referenced
this pull request
Sep 30, 2021
* Spinner component for loading * Spinner exports * Fix data-testid Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> * remove explicit children prop Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> * BREAKING CHANGE: Remove deprecated folders (#927) * feat(store-ui): adding list atom (#918) Create List component as an Atom. * feat(store-ui): Add Skeleton Atom (#911) * Add skeleton atom * Move animation to theme * Import tailwind utilities * Update test * Use only 1 div * Update story * Extend HTMLDivElement * Spinner exports * lint * Fix Spinner test * removing duplicated line in package.json Co-authored-by: Igor Brasileiro <brasileiro456@gmail.com> Co-authored-by: Tiago Gimenes <tlgimenes@gmail.com> Co-authored-by: Bento Pereira <40964933+bentoper@users.noreply.github.com> Co-authored-by: Larícia Mota <laricia.mota@vtex.com.br>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
As the title says, this PR creates the Spinner atom.
This PR is related to Loading Button component/task. After the refinement, we decided to create the Spinner atom and an example of Loading Button as a molecule.
How it works?
How to test it?
References