Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Housekeeping module name references #1414

Merged
merged 6 commits into from
Jul 22, 2022

Conversation

eduardoformiga
Copy link
Member

@eduardoformiga eduardoformiga commented Jul 21, 2022

What's the purpose of this pull request?

Housekeeping PR.

  • Updates from theme-b2c-tailwind to styles package.
  • Makes @faststore/ui storybook use the styles package.
  • Fixes plop style generator.
  • Updates some README.md and docs.
  • Removes unused @vtex/tsconfig from @faststore/ui.

References

#1326
#1379
#1296

@eduardoformiga eduardoformiga requested a review from a team as a code owner July 21, 2022 21:45
@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
faststore ✅ Ready (Inspect) Visit Preview Jul 21, 2022 at 9:45PM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 252fc08:

Sandbox Source
Store UI Typescript Configuration

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -30,7 +30,7 @@ export default (plop: NodePlopAPI) => {
},
{
type: 'add',
path: '../themes/theme-b2c-tailwind/src/{{atomicGroup}}/{{kebabCase name}}.css',
path: '../packages/styles/src/{{atomicGroup}}/{{kebabCase name}}.css',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I thought about it yesteday ~ and now it's updated 💯

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐜 mind reader 👁️

Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeeeee 💯 THANK YOU.

@eduardoformiga eduardoformiga merged commit 7cbf1eb into main Jul 22, 2022
@eduardoformiga eduardoformiga deleted the chore/updates-module-name-refs branch July 22, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants